Closed
Bug 549132
Opened 14 years ago
Closed 14 years ago
middle-mouse paste fails in text input field if it is empty and does not have focus
Categories
(Core :: Layout: Form Controls, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a3
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: elmar.ludwig, Assigned: mounir)
References
()
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
540 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a2pre) Gecko/20100227 Minefield/3.7a2pre ID:20100227031019 Using middle click to insert the current selection fails for input fields that do not have focus and are empty. If the field has focus or contains any text prior to the paste, middle-mouse paste works fine. Steps to reproduce: 1. load any page containing text input form controls, for example http://www.mcfedries.com/CreatingAWebPage/textarea.htm 2. select some text on the page 3. try to paste using middle-click into an empty text field Expected behaviour: selected text is inserted into the text field Actual behaviour: no text is unserted Regression range: firefox-3.7a2pre-2010-02-26-03: works firefox-3.7a2pre-2010-02-27-03: fails http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=475768f37b1a&tochange=4e1b68ecf126 -> bug 457800
Assignee | ||
Comment 1•14 years ago
|
||
The placeholder frame is taking the event preventing the other frame to take it. I will attach a patch tomorrow. Thank you for reporting.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•14 years ago
|
||
This patch is fixing the bug.
Attachment #429401 -
Flags: review?(bzbarsky)
Comment 3•14 years ago
|
||
So does this work because the anonymous div background is always transparent? I thought we'd put the placeholder on top to make sure it was visible.
Assignee | ||
Comment 4•14 years ago
|
||
Indeed. But is it possible to have a non-transparent value div as it is anonymous ? We may be able to do this in css with "pointer-events: none;". Would you prefer this solution ?
Comment 5•14 years ago
|
||
You should make the placeholder element click-through: 'pointer-events: none;'.
Assignee | ||
Comment 6•14 years ago
|
||
This patch sets the pointer-events to none for the placeholder div.
Attachment #429401 -
Attachment is obsolete: true
Attachment #429514 -
Flags: review?(bzbarsky)
Attachment #429401 -
Flags: review?(bzbarsky)
Comment 7•14 years ago
|
||
Comment on attachment 429514 [details] [diff] [review] Patch v0.2 Yeah, I like this a lot more. Shouldn't have as many surprises.
Attachment #429514 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 8•14 years ago
|
||
Thank you for your review.
blocking2.0: --- → ?
Keywords: checkin-needed
Comment 9•14 years ago
|
||
Landed as <http://hg.mozilla.org/mozilla-central/rev/f5bc344b91a6> Let's get some tests for this as well.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Updated•14 years ago
|
Target Milestone: mozilla1.9.3a2 → mozilla1.9.3a3
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite? → in-testsuite+
blocking2.0: ? → final+
Priority: -- → P2
You need to log in
before you can comment on or make changes to this bug.
Description
•