Closed
Bug 549176
Opened 14 years ago
Closed 9 days ago
Enable frecency calculations in Camino
Categories
(Camino Graveyard :: Location Bar & Autocomplete, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: chris, Assigned: chris)
References
Details
Attachments
(1 file)
2.04 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
We will probably want to use frecency of history and bookmark items when autocompleting from the URL bar (bug 504879). Right now Places sets frecency of history items to 0. To get everything working we need to do at least the following: 1. Set the relevent prefs in order for the proper frecencies to be calculated (http://mxr.mozilla.org/mozilla1.9.2/source/browser/app/profile/firefox.js#792). 2. Notify Places when a bookmark is opened. The logical place to do this is in MainController's |loadBookmark...| method. 3. Let Places know about Camino's bookmarks. Frecency calculations take into account whether a URL is bookmarked. A bonus is awarded if the visited URL is bookmarked, even if the URL wasn't opened from a bookmark. The internal methods query the bookmark service, so we need to keep that service synced up with Camino's bookmarks. 3 will take a bit of work, but 1 and 2 are straightforward and should be done before 2.1. Better to have frecencies being calculated before we need them, so when we do improve autocomplete it starts producing sensible results right away.
Assignee | ||
Comment 1•14 years ago
|
||
These prefs set the coefficients used in Places' frecency calculations. This is all we need to set in order to start getting non-zero frecency values in the Places database. Going straight to sr since it's just a straight copy and paste from Firefox's prefs file.
Assignee: nobody → trendyhendy2000
Status: NEW → ASSIGNED
Attachment #432458 -
Flags: superreview?(mikepinkerton)
Comment 2•14 years ago
|
||
Comment on attachment 432458 [details] [diff] [review] Part One: Setting Prefs [checked in] rs=hyatt
Attachment #432458 -
Flags: superreview?(mikepinkerton) → superreview+
Comment on attachment 432458 [details] [diff] [review] Part One: Setting Prefs [checked in] Landed on cvs trunk and the test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/4ce073a0d28e
Attachment #432458 -
Attachment description: Part One: Setting Prefs → Part One: Setting Prefs [checked in]
Blocks: 548464
(In reply to comment #3) > http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/4ce073a0d28e http://hg.mozilla.org/camino/rev/49c55173d392
Status: ASSIGNED → RESOLVED
Closed: 9 days ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•