549207 - My local Windows 2000 build fails to compile in js/src/jshashtable.h

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Serge Gautherie (:sgautherie)]

{
\js\src\jshashtable.h(81) : error C2248:
'js::HashMap<Key,Value,HashPolicy,AllocPolicy>::Entry::operator =' : cannot acce
ss private member declared in class 'js::HashMap<Key,Value,HashPolicy,AllocPolic
y>::Entry'
        with
        [
            Key=jsbytecode *,
            Value=size_t,
            HashPolicy=js::DefaultHasher<jsbytecode *>,
            AllocPolicy=js::SystemAllocPolicy
        ]
        \js\src\jshashtable.h(696) : see
declaration of 'js::HashMap<Key,Value,HashPolicy,AllocPolicy>::Entry::operator =
'
        with
        [
            Key=jsbytecode *,
            Value=size_t,
            HashPolicy=js::DefaultHasher<jsbytecode *>,
            AllocPolicy=js::SystemAllocPolicy
        ]
        \js\src\jshashtable.h(694) : see
declaration of 'js::HashMap<Key,Value,HashPolicy,AllocPolicy>::Entry'
        with
        [
            Key=jsbytecode *,
            Value=size_t,
            HashPolicy=js::DefaultHasher<jsbytecode *>,
            AllocPolicy=js::SystemAllocPolicy
        ]
        \js\src\jshashtable.h(81) : while
 compiling class template member function 'void js::detail::HashTable<T,HashPoli
cy,AllocPolicy>::Entry::setFree(void)'
        with
        [
            T=js::HashMap<jsbytecode *,size_t,js::DefaultHasher<jsbytecode *>,js
::SystemAllocPolicy>::Entry,
            HashPolicy=js::HashMap<jsbytecode *,size_t,js::DefaultHasher<jsbytec
ode *>,js::SystemAllocPolicy>::MapHashPolicy,
            AllocPolicy=js::SystemAllocPolicy
        ]
        /js/src/jstracer.cpp(1372) : see
reference to class template instantiation 'js::detail::HashTable<T,HashPolicy,Al
locPolicy>::Entry' being compiled
        with
        [
            T=js::HashMap<jsbytecode *,size_t,js::DefaultHasher<jsbytecode *>,js
::SystemAllocPolicy>::Entry,
            HashPolicy=js::HashMap<jsbytecode *,size_t,js::DefaultHasher<jsbytec
ode *>,js::SystemAllocPolicy>::MapHashPolicy,
            AllocPolicy=js::SystemAllocPolicy
        ]
make[5]: *** [jstracer.obj] Error 2
}

I'm trying to find out which changeset caused this...

Comment 1

[Serge Gautherie (:sgautherie)]

Regression timeframe:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a8d65f5da19a&tochange=7b1d42444f85
though I don't know why it displays empty instead of 20 changesets.

I tried 2 changesets in between but had other failures :-/

Fwiw, I'm using
Platform SDK directory: [...]\Microsoft Platform SDK for Windows Server 2003 R2
Setting environment for using Microsoft Visual Studio 2005 x86 tools.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> though I don't know why it displays empty instead of 20 changesets.

Ah, because they are in the same push:
http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=69627183a733

Comment 3

[Boris Zbarsky [:bzbarsky]]

What compiler are you using?  gcc 4.0 has a known template bug that makes it miscompile this file, and your error is looking very similar.  It might be that your compiler is just buggy...

Comment 4

[Luke Wagner [:luke]]

Could you try replacing your js/src/jshashtable.h with http://hg.mozilla.org/tracemonkey/file/7a2c87fe31b7/js/src/jshashtable.h and see if that works?  We had some issues with various compiler versions and friend declarations / access protection in the templatey world of jshashtable.h, and I guess the fixes haven't been pushed to m-c yet.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)

(In reply to comment #1)
> Setting environment for using Microsoft Visual Studio 2005 x86 tools.

= "Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 14.00.50727.42 for 80x86"

***

(In reply to comment #4)

From that changeset,
jshashtable.h alone: gives me another error;
+ jstracer.cpp: yet another error.

Then I can't tell.

Comment 6

[Luke Wagner [:luke]]

Hmm.  Can you build tracemonkey tip?

Comment 7

[Serge Gautherie (:sgautherie)]

No, I don't use that repository.

Comment 8

[Luke Wagner [:luke]]

Alright then... well the error should be fixed on m-c by the next merge from tracemonkey.

Comment 9

[Serge Gautherie (:sgautherie)]

Any ETA.?.

Comment 10

[Luke Wagner [:luke]]

Rob Sayre tends to merge with m-c on a weekly basis, assuming tm is green.

Comment 11

[Serge Gautherie (:sgautherie)]

Eventually fixed by today merge:
http://hg.mozilla.org/mozilla-central/rev/03136ff6b1a8
(+ http://hg.mozilla.org/mozilla-central/rev/2b30f6f99313)

V.Fixed locally.