Open Bug 549261 Opened 14 years ago Updated 8 years ago

Deleting message from its own window does not update 3-pane window's Edit -> Undo state lost if 'Close message window on delete' is enabled

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
macOS
defect
Not set
critical

Tracking

(Not tracked)

People

(Reporter: chris, Unassigned)

References

Details

(Keywords: dataloss)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_2; en-us) AppleWebKit/531.21.8 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3

If, while reading a message in its own window, you delete the message - the current message window's Edit -> Undo will properly become 'Undo Delete Message' but the 3-pane window will not know about it and not change state. It will either be grayed out or it will retain the same value it did. This can become very confusing when 'Close message window on delete' is checked.

Reproducible: Always

Steps to Reproduce:
1. Open message in new window
2. Delete message
3a. If 'Close message window on delete' is UNchecked, Edit -> Undo shows 'Undo Delete Message', which works.
3b. If 'Close message window on delete' is checked, or if you switch to the 3-pane window, Edit -> Undo is grayed out and unavailable.
Actual Results:  
3-pane window's Edit -> Undo is not updated

Expected Results:  
3-pane window's Edit -> Undo should be updated to 'Undo Deleted Message'

If you continue the test by manually moving the message from Trash to Inbox, Edit -> Undo becomes 'Undo Move Message'. If you then repeat the above steps on the same email and come back to the 3-pane window, Edit -> Undo will still be 'Undo Move Message' and TB will dutifully try to Undo the move of the message from Trash to Inbox. Since the message is already back in the Trash, an empty message is created in Trash with a date of 12/31/69 7:00 PM.
Version: unspecified → 3.0
Oh yes, this is POP.

chris
each window has its own undo state, and always has. If you close a window, you lose the undo state for that window.
Hmm... guess I never noticed it in v2! I think what made me notice it was my experimentation with the 'Close message window on delete' setting.

Should I change this bug to an enhancement request for the 3-pane window being a 'master' window that keeps its Edit -> Undo/Redo in sync with the most recent from any window?

thanks,

chris
Blocks: tabsmeta
(don't know why I made this block tabsmeta, so removing)

(In reply to Chris Denesha from comment #3)
> Should I change this bug to an enhancement request for the 3-pane window
> being a 'master' window that keeps its Edit -> Undo/Redo in sync with the
> most recent from any window?

 'Close message window on delete' is checked does make it problematic
No longer blocks: tabsmeta
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: dataloss
Summary: Deleting message from its own window does not update 3-pane window's Edit -> Undo state → Deleting message from its own window does not update 3-pane window's Edit -> Undo state lost if 'Close message window on delete' is enabled
I have to agree with Chris, the Undo function is confusing and unintuitive as is (V8.0.1 on Mac).  Even with "close message window on delete" NOT checked it behaves unexpectedly.

If you have an email open, then use the Delete key, it goes to the Trash.  But if you then try to use Undo from the Inbox, what comes back is a previously deleted message, not the one you just deleted.  Other similar things happen with Undo Delete and Undo Move, possibly caused by each window having its own Undo state.
You need to log in before you can comment on or make changes to this bug.