549290 - Title of common dialogs no longer bold on Mac

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

Before the patch from bug 459457, there was this CSS rule in formatting.css:
 #commonDialog .dialogTitle {
   font-weight: bold !important;
 }

After the patch, it became this in commonDialog.css:
 .dialogTitle {
   font-weight: bold;
 }

Without !important, the rule has no effect because there's another rule just above it which causes the font attributes to use system values:
 #info\.title,
 #info\.header,
 #info\.body {
   font: menu;
   line-height: 16px;
   margin-bottom: 6px;
 }

Comment 1

[Dão Gottwald [:dao]]

Can this just use #info\.title instead? Does dialogTitle need to exist at all?

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch v2

(In reply to comment #1)
> Can this just use #info\.title instead?
Yes.

>Does dialogTitle need to exist at all?
No... or at least I couldn't find any use for it with mxr. I removed it in this second patch. Let's hope it won't break any theme.

Comment 3

[Florian Quèze [:florian]]

http://hg.mozilla.org/mozilla-central/rev/20fce9e19782