Closed
Bug 549291
Opened 14 years ago
Closed 13 years ago
Remove leftovers from MOZ_STATIC_COMPONENTS
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla7
People
(Reporter: sgautherie, Assigned: emorley)
References
Details
Attachments
(1 file)
|
9.56 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
After bug 520339, it looks like MOZ_META_COMPONENTS could be removed too? http://mxr.mozilla.org/mozilla-central/search?string=MOZ_META_COMPONENTS&case=1&find=akefile And MOZ_STATIC_COMPONENTS too?? http://mxr.mozilla.org/mozilla-central/search?string=MOZ_STATIC_COMPONENTS&case=1&find=/toolkit-makefiles.sh$
|
Reporter | |
Updated•14 years ago
|
Product: Core → Toolkit
|
||
Comment 1•13 years ago
|
||
Bug 420707 is handling the MOZ_META_COMPONENTS case. I think MOZ_STATIC_COMPONENTS can probably be removed as well, but you'd probably want to see if modules/staticmod/ can also be removed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Remove leftovers from MOZ_META_COMPONENTS (and MOZ_STATIC_COMPONENTS) → Remove leftovers from MOZ_STATIC_COMPONENTS
|
Assignee | |
Comment 2•13 years ago
|
||
The only instance left from the MXR searches in comment 0, is in toolkit-makefiles.sh: http://mxr.mozilla.org/mozilla-central/source/toolkit/toolkit-makefiles.sh#1129
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://tbpl.mozilla.org/?tree=Try&rev=67edbfca3840 Thanks :-)
Attachment #536162 -
Flags: review?(ted.mielczarek)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 536162 [details] [diff] [review] Remove MOZ_STATIC_COMPONENTS Review of attachment 536162 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #536162 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Has passed try (comment 3), author & commit message filled out. Thanks to whomever checks it in :-)
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/05c78fa039f0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
|
||
Comment 7•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
The files ("modules/staticmod/Makefile.in" , "modules/staticmod/nsMetaModule.cpp") have been removed from the repo. Based on that I'm marking this as VERIFIED FIXED.Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•