54930 - $MOZILLA_FIVE_HOME should be $MOZILLA_HOME

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Sean Chitwood]

I realize this is a trivial bug, but for consistency MOZILLA_FIVE_HOME should be
changed to MOZILLA_SIX_HOME

Comment 1

[Doron Rosenberg (IBM)]

do you mean changing the directory or a variable?

Comment 2

[Sean Chitwood]

Sorry, I was unclear. I meant the variable name. Just for consistencies sake.

Comment 3

[Doron Rosenberg (IBM)]

duh, you used a '$' (slaps himself)

calling it $MOZILLA_HOME would be better.  No idea where this goes.

Comment 4

[Sean Chitwood]

Attachment: Patch to Change $MOZILLA_FIVE_HOME to $MOZILLA_HOME

Comment 5

[Doron Rosenberg (IBM)]

I have no idea where to move this. WHat files are you patching with this?

Comment 6

[Sean Chitwood]

My patch touches the following files....

I know that there is no clear owner, as a matter of fact, on IRC there was no
clear decision as to what the variable name should be.

/cvsroot/mozilla/build/package/debian/runner,v
/cvsroot/mozilla/build/package/rpm/mozilla,v
/cvsroot/mozilla/build/package/rpm/mozilla-viewer,v
/cvsroot/mozilla/build/unix/run-mozilla.sh,v
/cvsroot/mozilla/config/rules.mk,v
/cvsroot/mozilla/extensions/irc/xul/tests/index.html,v
/cvsroot/mozilla/layout/html/tests/table/rtest.sh,v
/cvsroot/mozilla/layout/html/tests/table/runtests.sh,v
/cvsroot/mozilla/modules/libpref/src/prefapi.c,v
/cvsroot/mozilla/modules/oji/tests/script/autorun.pl,v
/cvsroot/mozilla/modules/plugin/nglsrc/nsPluginsDirBeOS.cpp,v
/cvsroot/mozilla/modules/plugin/nglsrc/nsPluginsDirUNIX.cpp,v
netwerk/cache/filecache/test/diskcache.cpp
/cvsroot/mozilla/netwerk/cache/filecache/test/diskcache.cpp,v
/cvsroot/mozilla/netwerk/test/TestRawCache.cpp,v
/cvsroot/mozilla/xpcom/doc/xpcom-standalone.html,v
/cvsroot/mozilla/xpcom/io/nsDirectoryService.cpp,v
/cvsroot/mozilla/xpcom/io/nsSpecialSystemDirectory.cpp,v
xpfe/appfilelocprovider/src/nsAppFileLocationProvider.cpp
/cvsroot/mozilla/xpfe/appfilelocprovider/src/nsAppFileLocationProvider.cpp,v
/cvsroot/mozilla/xpinstall/packager/unix/mozilla.sh,v
/cvsroot/mozilla/xpinstall/packager/unix/mozilla.spec.in,v
/cvsroot/mozilla/xpinstall/wizard/unix/src2/mozilla-installer,v

Comment 7

[Asa Dotzler [:asa]]

Sean, can you reassign this bug to yourself and try to get review and approval
to check it in.

Comment 8

[Sean Chitwood]

Reassigning to Myself as per Asa's request. Will haunt IRC to get approval.

Comment 9

[Sean Chitwood]

Attachment: r= [e-mail]

Comment 10

[Doron Rosenberg (IBM)]

Now you need a sr= and a a=.  DO you have cvs rights?

Comment 11

[Doron Rosenberg (IBM)]

confirming

Comment 12

[Andreas Franke (gone)]

I'm not a native speaker, so I had to lookup the meaning of LAIR. Though it fits
nicely, I'd prefer MOZILLA_HOME since the meaning is obvious to everyone,
including non-native speakers. Please consider this side-effect.

Comment 13

[timeless]

IMO extensions/irc/xul/tests/index.html should not include this information.

Leaf/Cls please pick a component. I think this is a dupe, although there are 
patches on this bug.

Comment 14

[Ben Bucksch (:BenB)]

> for consistency MOZILLA_FIVE_HOME should be changed to MOZILLA_SIX_HOME

huh? What is Mozilla 6?

Comment 15

[Peter "jag" Annema]

Mozilla 6 ne Mozilla 6.0, fwiw :-)

(Like it or not, there have been 4 Mozillas[0] before this one, 5 if you count
the one which was never released)

[0] A rose, by any other name ...

Comment 16

[cls]

I don't like lair either.  I'm casting my vote for --enable-default-mozilla-home
and MOZILLA_HOME.  In previous "mozilla" releases, it's has always been
MOZILLA_HOME.  I don't see the need to change it.

Comment 17

[Benjamin Smedberg]

The only thing we should do is remove MOZILLA_FIVE_HOME entirely, but in the meantime let's not mess with it.