549350 - Implement search forms in Kitsune

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[James Socol [:jsocol, :james]]

Now that we have results, we need forms. This probably requires two additional models to pick up the list of Forums and the list of Categories.

Comment 1

[Paul Craciunoiu [:paulc]]

I started with the forums but the models work should have gone in first.
Created a temporary branch bug-549350-models on github. Will merge back into development and rebase to continue branch work.

Comment 2

[Paul Craciunoiu [:paulc]]

(In reply to comment #1)
> I started with the forums
s/forums/forms (i.e. search forms)

Comment 3

[Paul Craciunoiu [:paulc]]

James: r? at:
http://github.com/pcraciunoiu/kitsune/commit/ee32488a29a8b24f61f2f78c8c30af07a7ee4b2d
(see also previous commits).

It should be all done with these exceptions:
* JS not yet localized
* _lazy gettext not yet available

(looked at http://github.com/pcraciunoiu/kitsune/commit/954c9d13599a114da9ce5cd87fa50c25a840e87a for the remaining ones)

We could just do a separate bug for these two issues I think, or keep it here if you prefer.

Comment 4

[Paul Craciunoiu [:paulc]]

Merged to development at:
http://github.com/jsocol/kitsune/commit/80fd3f4b289d08545d9591e40e78d0b7d20e048b

Just noticed that we need to update the pager to work with the filters. Filed bug 554204 for this.

Also, for the above JS localization, filed bug 554205.

Comment 5

[Paul Craciunoiu [:paulc]]

Of course I should have added that James reviewed it first :)

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; Vishal and I have done enough testing to know this is implemented, and we've been filing bugs all along the way...