Profile js code should use profile as a service not component

VERIFIED FIXED

Status

P3
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: ccarlen, Assigned: ccarlen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

18 years ago
The code here:
<http://lxr.mozilla.org/seamonkey/source/profile/resources/content/createProfileWizard.js#26>
creates an instance of the profile mgr. It should instead get it as a service.
This problem causes some ugly business in nsProfile's constructor/destructor
because it needs to make sure that it initializes its registry access only once.
Ben, feel free to reassign this to me if you're busy.
(Assignee)

Comment 1

18 years ago
Reassigning to myself because I need to touch this file for bug 46866 and I can
do it then.
Assignee: ben → ccarlen
Summary: Profile js code should use profile as a service not component → Profile js code should use profile as a service not component
(Assignee)

Comment 2

18 years ago
I've made the change and it's getting reviewed.
Status: NEW → ASSIGNED
(Assignee)

Comment 3

18 years ago
Fix checked into trunk. Verify by seeing that the calls to
createInstance(nsIProfile) have been replaced by getService in the profile front
end js code.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 4

18 years ago
verified code change
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.