549452 - nsGlobalWindow::SetNewDocument is hard to read

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch -w

The recursion and the fact that most code is in one way or another if-ed out of the inner resp. outer window is making this code very hard to read.

Attaching a ignore-whitespace patch first for reviewing ease.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 429607 [details] [diff] [review]
Patch to fix

This is awesome!

Only comment I have is that nsGlobalWindow::InnerWindowSetNewDocument is a little awkward. I think something like ::InnerSetNewDocument sounds a little better.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 429607 [details] [diff] [review]
Patch to fix

Looks good, but you'll need to bump the IID for nsPIDOMWindow.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Oops, forgot to address Blakes review comment. Fixed as

http://hg.mozilla.org/mozilla-central/rev/28be6df4ba12

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Err.. of course the main fix is

http://hg.mozilla.org/mozilla-central/rev/ac81e4eeb289

Thanks for the reviews!