nsprpub/pr/tests/append.c fails on a temp file creation.
Created attachment 429628 [details] [diff] [review] Fix the temp file location
Created attachment 429629 [details] [diff] [review] Fix the temp file location Missed the "const".
not to over engineer this, but its probably more robust to do something like this: http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/tests/testfile.c#957 I think its safe to default to /tmp for *nix, but on win32 we should use GetTempPath.
(In reply to comment #3) > I think its safe to default to /tmp for *nix, but on win32 we should use > GetTempPath. We can do this, though it won't make a big difference, as the other tests create a bunch of files and dirs in the root folder anyway.
we also need a similar fix in nameshm1.c. Can you put together one patch that fixes all of them?
sem* tests also use a fixed /tmp/* file name.
Created attachment 430760 [details] [diff] [review] append patch v3 This is a patch using GetTempPath() for append test only. If it's OK, I'll propagate it to the other tests. It would make sense to move this new GetFullTempFileName() function to a separate header and include it in the other tests. I'm not sure though if it's the way to go, as such approach for the common code was not used in nspr tests before, even though they do have some functionality, which could be shared. So any suggestions are welcome.
Comment on attachment 430760 [details] [diff] [review] append patch v3 per irc, alex is going to move this logic to a header so it can be shared by all tests. Wan-Teh, if you have any objections or suggestions here, let me know.