If compose window initialisation fails, don't hide the error by throwing it to the text console

RESOLVED FIXED in Thunderbird 3.1b2


10 years ago
10 years ago


(Reporter: standard8, Assigned: standard8)


(Blocks 1 bug)

Thunderbird 3.1b2
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird3.0 .4-fixed)



(2 attachments)

Posted patch Trunk fixSplinter Review
Catching an error and dumping it to the text console just isn't nice. The compose window does this if it has an issue whilst opening. It displays a pretty dialog, but that's not much help to the user.

The code has support for printing an error message to the string, and all our locales do as well, but we just end up printing ""...

I think a chrome error in the dialog is likely to scare users - especially if its intermittent or rare, so just put the error into the error console, and if we get someone having persistent problems, then we can point them in the right direction.

I've got two patches to do this, one to change the string on trunk, the second to just change the dump location on the TB 3.0.x builds.
Attachment #429692 - Flags: review?(philringnalda)
Attachment #429693 - Flags: review?(philringnalda)
Phil: review ping.
Attachment #429692 - Flags: review?(philringnalda) → review?(bienvenu)
Attachment #429693 - Flags: review?(philringnalda) → review?(bienvenu)
Comment on attachment 429693 [details] [diff] [review]
3.0 branch patch

looks reasonable...
Attachment #429693 - Flags: review?(bienvenu) → review+
Attachment #429692 - Flags: review?(bienvenu) → review+
Checked in the trunk patch: http://hg.mozilla.org/comm-central/rev/884335fd11a0
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 429693 [details] [diff] [review]
3.0 branch patch

a=Standard8 for minor correctness fix that should help with debugging issues with users of released builds.
Attachment #429693 - Flags: approval-thunderbird3.0.4+
You need to log in before you can comment on or make changes to this bug.