Closed Bug 549637 Opened 14 years ago Closed 14 years ago

build toolkit/components when building toolkit/, rather than separately

Categories

(Toolkit Graveyard :: Build Config, defect)

Product:
Toolkit Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a4

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file)

patch
1.17 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Because I can't think of a good reason for us to need to remember to rebuild toolkit/components separately.
Attached patch patch — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #429771 -
        Flags: review?(ted.mielczarek)

    
    

    
  
No failures on a clobber build, I'll push to try.

    
    

    
  
No failures on try either.

    
    

    
  
Comment on attachment 429771 [details] [diff] [review]
patch

Seems reasonable. Who knows why it was split out in the first place?

        Attachment #429771 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
It looks like it was initially split off in bug 280725. I don't understand why, though.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/20c9f687ee2c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4

    
    

    
  
(In reply to comment #5)
> I don't understand why, though.
Because back then toolkit was still inside an #ifdef.

    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.