build toolkit/components when building toolkit/, rather than separately

RESOLVED FIXED in mozilla1.9.3a4

Status

defect
RESOLVED FIXED
10 years ago
8 months ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
mozilla1.9.3a4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Because I can't think of a good reason for us to need to remember to rebuild toolkit/components separately.
Posted patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #429771 - Flags: review?(ted.mielczarek)
No failures on a clobber build, I'll push to try.
No failures on try either.
Comment on attachment 429771 [details] [diff] [review]
patch

Seems reasonable. Who knows why it was split out in the first place?
Attachment #429771 - Flags: review?(ted.mielczarek) → review+
It looks like it was initially split off in bug 280725. I don't understand why, though.
https://hg.mozilla.org/mozilla-central/rev/20c9f687ee2c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a4
(In reply to comment #5)
> I don't understand why, though.
Because back then toolkit was still inside an #ifdef.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.