549747 - Crash with null texture argument to framebufferTexture2D [@ mozilla::WebGLContext::FramebufferTexture2D(unsigned int, unsigned int, unsigned int, nsIWebGLTexture*, int) ]

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Markus Stange [:mstange]]

Attachment: patch

WebGLContext::FramebufferTexture2D calls tex->GLName() without null-checking tex.
While looking for other occurrences of that problem in the file I found a bad null check of "prog" in WebGLContext::ValidateProgram and I figured it's not worth creating a separate patch for that one.

Where would a crashtest go? I didn't find any WebGL tests.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 429854 [details] [diff] [review]
patch

This looks ok, thanks -- no crashtests set up yet, feel free to create the directory though (make a canvas/canvas/test/webgl directory)

Comment 2

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/e3c94358dfa5
http://hg.mozilla.org/mozilla-central/rev/04497f41d4e0

I didn't add a test - I'd like a separate review on the test infrastructure so I'll do it in a separate bug.