549781 - Remove unwrapping of encrypted payloads

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Ed Lee :Mardak]

Bug 549636 removes the [wrap]; see attachment 429751 [details] [diff] [review].

Relevant changes to the current iphone client data: history/bookmarks/tabs..

History:
http://hg.mozilla.org/labs/weaveclient-iphone/file/dca2696f11d3/Network%20And%20Storage/Store.m#l860
No need to iterate over the NSArray historyArray (which should only have been looping once anyway) and just directly access the object.

(I don't know objective C, so I'm making up syntax from some existing code... :p)

NSDictionary *hist = [json JSONValue];

Bookmarks/Tabs:
http://hg.mozilla.org/labs/weaveclient-iphone/file/dca2696f11d3/Network%20And%20Storage/Store.m#l822
No need to read as array and [bmkArray objectAtIndex:0]

Same for tabs..
http://hg.mozilla.org/labs/weaveclient-iphone/file/dca2696f11d3/Network%20And%20Storage/Store.m#l888

Interesting that the data types have 3 different method signatures:
1) addHistorySet:(NSString *)json -> enumerator
2) addBookmarkRecord:(NSString *)json -> array -> index 0
3) addTabSet:(NSArray *)tabSetDict -> index 0

Comment 1

[Tony Chung [:tchung]]

Moving FFHome-related bugs to new component -> Firefox Home