In the current PR3 builds, all <hr>s come out too tall. A regular <hr> with no height or CSS looks like it's 3-4 pixels tall, where 4.x renders it as 1 px tall.
yes, I see a difference between the debug build on my machine and the PR3 release build. I'll try to track it down.
Status: NEW → ASSIGNED
OS: Mac System 8.5 → All
Priority: P3 → P2
Hardware: Macintosh → All
dammit, this is caused by me not getting the final version of my fix for bug 53568 in before beta3 deadline. I have the fix in hand, and I didn't see the bug myself because it ain't in my tree. (And I plain didn't notice doing my dogfood testing.) I'll attach the patch, get another review, approval, etc. Trivial change to make this right. Karnaze and waterson, can you guys look over the diff I'm about to attach. You've seen it already, this is just the cleaned-up version (the version that checks the border width rather than using a hardcoded value.)
chris and chris: The attached patch does 2 things: 1) it moves the prior fix up into the if (NS_UNCONSTRAINEDSIZE != aReflowState.mComputedHeight) case, so default sizing is uneffected. This is primarily what Simon was complaining about here. I'm a dope for missing that for beta3. 2) it adds in waterson's very reasonable request for basing the adjustment on the actual top and bottom border, rather than hardcoding in the observed default value. The diff is a little hard to read because of (1). But it's just moving a block of code up into the "if" clause so the calculation in the "else" clause isn't effected.
My only nit would be to move "PRBool noShadeAttribute = GetNoShade()" into the "if" statement because it's only ever used "if (thickness != onePixel)". Your call. sr=waterson
adding rtm+ per karnaze's verbal approval to put on PDT radar. very low risk, gives us much better 4xp on many top100 pages. very visible problem.
PDT marking [rtm++] this week, but would be minus real soon now. Let's focus on crashers.
fix checked into branch
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
checked into tip as well
marking verified in the Oct 6th build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.