55007 - mozilla/client.mak typos related to LDAP C SDK

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Wan-Teh Chang]

mozilla/client.mak has two typos related to LDAP C SDK.
In two places, 'LDAPCSDK_CO_TAG' is misspelled as
'LDAP_SDK_CO_TAG' or 'LDAPSDK_CO_TAG'.  The effect is
that people may mistakenly think they override the
LDAP C SDK cvs tag but still get the default
LDAPCSDK_40_BRANCH tag.

Just look at mozilla/client.mak on Netscape_20000922_BRANCH
(revision 3.83.4.4) as an example.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[cls]

dmose, care to review?

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Good catch, wtc.  This bug is on the trunk as well.

Patch looks good; r=[e-mail]

Comment 4

[cls]

Patch has been checked into the trunk. 

Comment 5

[Wan-Teh Chang]

This patch must be checked into the Netscape 6 release branch;
otherwise you will have a Netscape 6 release tag that pulls
LDAPCSDK_40_BRANCH, which means you may not be able to reproduce
the build in the future if there are new changes checked in on
the LDAPCSDK_40_BRANCH.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

LDAP isn't part of the commercial build, and as far as I know, noone is actually
depending on it working from Netscape's commercial branch.

Comment 7

[Wan-Teh Chang]

Then the LDAP source code should not be checked out
at all when building SeaMonkey.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Nor should xmlterm or chatzilla or xmlrpc or other optional components.  But
that's the level of build-system modularity that we've got at the moment.  In
any case, I hope to have the LDAP-URL stuff turned on in the default build in
the not-too-distant future.

Comment 9

[Jon Granrose]

verified.