55011 - We can't localize start page on messenger

Status: VERIFIED FIXED

(MailNews Core :: Localization, defect, P2)

Description

[Kazu Yamamoto]

We can modify start page on navigator by language pack
because its URL is in chrome/navigator/navigator.properties.
So we can localize start page by language pack.

But we couldn't localize start page on messenger
because its URL is in pref/mailnews.js/mailnews.start_page.url

I think mailnews.js should not be modified be language pack.
Please move mailnews.start_page.url from mailnews.js to messenger.properties.

Comment 1

[rchen]

Reassigned to Allan.

Comment 2

[Allan Masri]

mailnews.start_page.url resides in messenger-ns.properties. This file was
inadvertantly left out of PR-3. See bug 2458.

Comment 3

[Kazu Yamamoto]

???
I'm reopening this problem.

There isn't messenger-ns.properties in current mozilla.
The resource of mailnews.start_page.url is in defaults/pref/mailnews.js.

You SHOULD move this resource into 
chrome/*/locale/*/messenger/messenger.properties for localization works.

chrome/*/locale/*/navigator/navigator.properties contains 
browser.startup.homepage.

Do you understand?
And bug 2458 has nothing to do with this problem.

Comment 4

[Allan Masri]

I'm sorry, I misunderstood. In bugscape 2458, a similar problem is discussed. 
I'm assigning this to nhotta. If this change is made, both problems will be 
resolved.

Comment 5

[nhottanscp]

Attachment: patch to move "mailnews.start_page.url" to property

Comment 6

[nhottanscp]

Tao, could you review this? We also need to change commercial files.
Nominating for rtm, start up page has to be localizable.

Comment 7

[tao]

looks good. r=tao

Comment 8

[nhottanscp]

I found a problem, "Restore Default" does not work with the patch.
Tao, is there equivalence of CopyDefaultCharPref for localized pref?

Comment 9

[nhottanscp]

We need to add getDefaultLocalizedUnicharPref. Or do the redirection in the
client JS code.

Comment 10

[Frank Tang]

do you need to change anything in the /ns tree ?

Comment 11

[nhottanscp]

See bugscape 2458 for the commercial changes.

Comment 12

[nhottanscp]

Change to P2.

Comment 13

[Frank Tang]

I think we need to fix this for rtm.

Comment 14

[nhottanscp]

Attachment: a new patch (old patch plus changes for libpref).

Comment 15

[nhottanscp]

In new patch, I added getDefaultLocalizedUnicharPref
 to nsIPref. And changed pref-mailnews.js to use it so it can restore the
default value.
Tao, could you review the changed part before I send it for super review?
Also adding alecf to cc.

Comment 16

[tao]

I thought I did; perhaps, I didn't commit it. -> peer review =tao.

Comment 17

[Alec Flett]

sr=alecf

Comment 18

[Phil Peterson]

PDT marking [rtm++]

Comment 19

[nhottanscp]

Checked in the patch to branch, will check in to trunk tomorrow.

Comment 20

[nhottanscp]

Checked in to the trunk.

Comment 21

[Katsuhiko Momoi]

** Checked with 10/30/2000 MN build & 10/27/2000 Mtrunk build **

The fix for this bug involved the folowing:

1. That the "mailnews.start_page.url" in mailnews.js and mailnews-ns.js
   be moved to

    a. locale/Lang-Region/messenger/messenger.properties
    b. locale/Lang-Region/messenger/messenger-ns.properties

    (a is used by Mozilla, b is used by NS6)

2. That the default page URL specified in 1a and 1b can be restored
   via "Edit | Preferences | Mail & Newsgroup | Mail Start Page" preference setting.
   You can use the "Restore" button when you have set the start page to
   something else first using the above preference setting.

With the above builds (both NS6 and Mozilla for the Mtrunk build), the desired
results
mentioned in 1 and 2 above have been achieved. The pref item now resides in
the 2 proprties files under the chrome directory and the Restore button works as
intended.

Marking the fix verified for both the NS6 branch and Mozilla Trunk builds.