Closed Bug 550145 Opened 10 years ago Closed 10 years ago

NS_APPSTARTUP_CONTRACTID should exist in nsToolkitCompsCID.h and not nsXPFEComponentsCID.h (kill nsXPFEComponentsCID.h)

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a3

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
NS_APPSTARTUP_CONTRACTID is now used exclusively in toolkit despite the fact it is still defined in nsXPFEComponentsCID.h:

http://mxr.mozilla.org/comm-central/search?string=NS_APPSTARTUP_CONTRACTID

NS_COMMANDLINESERVICE_CONTRACTID is also defined in nsXPFEComponentsCID.h but that isn't used anywhere:

http://mxr.mozilla.org/comm-central/search?string=+NS_COMMANDLINESERVICE_CONTRACTID&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Therefore, we should move NS_APPSTARTUP_CONTRACTID to nsToolkitCompsCID.h and then we can just kill nsXPFEComponentsCID.h.

Attaching patch to do just this. Tested on try server and it built just fine.
Attachment #430256 - Attachment is patch: true
Attachment #430256 - Attachment mime type: application/octet-stream → text/plain
Attachment #430256 - Flags: review?(benjamin)
Blocks: 550146
Attachment #430256 - Flags: review?(benjamin) → review+
Checked in: http://hg.mozilla.org/mozilla-central/rev/c2060d652ccb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a3
You need to log in before you can comment on or make changes to this bug.