550173 - [dashboard] Switch off DEBUG, create a good error page

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect, P1)

Description

[Axel Hecht [:Pike]]

We'll need a descent 500 handler, and switch off DEBUG. I think that's the leak we're seeing in the twistd daemon.

Comment 1

[Axel Hecht [:Pike]]

... and in the buildbot master, too.

The culprit are that with DEBUG on, we're keeping a log of all sql queries in django.db.connection.queries.

Comment 2

[Staś Małolepszy :stas]

Let me try to cook something up here.

Comment 3

[Staś Małolepszy :stas]

Attachment: Patch A. Add a 500.html template

Pike, can you take a look and tell me if you like it?

Comment 4

[Staś Małolepszy :stas]

Django docs say that "If DEBUG is set to False  (in your settings module) and if you didn't create a 404.html  file, an Http500  is raised instead. So remember to create a 404.html."

I'll add 404.html to the patch tomorrow.

Comment 5

[Staś Małolepszy :stas]

Attachment: Patch B. Add 404 too

I added a simple 404.html in this patch. Bug 574143 tracks making it better.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 453492 [details] [diff] [review]
Patch B. Add 404 too

r=me.

Comment 7

[Staś Małolepszy :stas]

http://hg.mozilla.org/l10n/django-site/rev/85a5d42908dd

Pike, can you patch local_settings.py (add SERVER_EMAIL) on the vm?

Comment 8

[Axel Hecht [:Pike]]

I've set things up to use [e-mail], though that doesn't receive replies.

Right now, the server doesn't send out mails, there's nothing listening to port 25 on localhost. I filed bug 574178 on how to set things up to send mails.

Comment 9

[Axel Hecht [:Pike]]

Landed a corresponding fix for l10n-master, http://hg.mozilla.org/users/axel_mozilla.com/l10n-master/rev/903818058c19