Note: There are a few cases of duplicates in user autocompletion which are being worked on.

vorbis_analysis_headerout calls oggpack_writeclear with uninitialized ogb if !v->backend_state

RESOLVED FIXED

Status

()

Core
Audio/Video
--
major
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: timeless, Assigned: cajbir)

Tracking

({coverity})

Trunk
x86
All
coverity
Points:
---

Firefox Tracking Flags

(status1.9.2 .2-fixed, status1.9.1 .9-fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
567  	int vorbis_analysis_headerout(vorbis_dsp_state *v,
568  	                              vorbis_comment *vc,
569  	                              ogg_packet *op,
570  	                              ogg_packet *op_comm,
571  	                              ogg_packet *op_code){

574  	  oggpack_buffer opb;
575  	  private_state *b=v->backend_state;

577  	  if(!b){
578  	    ret=OV_EFAULT;
579  	    goto err_out;

630  	 err_out:
631  	  oggpack_writeclear(&opb);
(Assignee)

Comment 1

8 years ago
Raised as trac ticket #1656 in the Xiph bug system:

https://trac.xiph.org/ticket/1656
(Assignee)

Comment 2

8 years ago
Patch suggested by Tim Terryberry:

http://pastebin.com/SzAsqYaM
Assignee: nobody → chris.double
(Assignee)

Comment 3

8 years ago
Created attachment 430413 [details] [diff] [review]
Fix

Patch attached based on Tim's patch (Apologies for spelling Tim's last name wrong in the previous comment).
Attachment #430413 - Flags: review?(chris)
Attachment #430413 - Flags: review?(chris) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
status1.9.1: --- → wanted
status1.9.2: --- → wanted
http://hg.mozilla.org/mozilla-central/rev/d63280421a8d

We should get this on branch eh?
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Attachment #430413 - Flags: approval1.9.2.2?
Attachment #430413 - Flags: approval1.9.1.9?
Keywords: checkin-needed
Comment on attachment 430413 [details] [diff] [review]
Fix

a=beltzner for 1.9.2.2 and 1.9.1.9
Attachment #430413 - Flags: approval1.9.2.2?
Attachment #430413 - Flags: approval1.9.2.2+
Attachment #430413 - Flags: approval1.9.1.9?
Attachment #430413 - Flags: approval1.9.1.9+
Whiteboard: [needs 191 landing][needs 192 landing]
(Reporter)

Comment 6

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c57eeb94d898
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fa02f59ba2f9
status1.9.1: wanted → .9-fixed
status1.9.2: wanted → .2-fixed
Thanks timeless!
Whiteboard: [needs 191 landing][needs 192 landing]
Is there a way to test this?
(Assignee)

Comment 9

7 years ago
Not that I'm aware of.
You need to log in before you can comment on or make changes to this bug.