Closed Bug 550190 Opened 10 years ago Closed 10 years ago

nsTextFrame::GetCharacterOffsetAtFramePointInternal returns garbage when EnsureTextRun() fails

Categories

(Core :: Layout: Text and Fonts, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: timeless, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

743 nsContentEventHandler::OnQueryCharacterAtPoint(nsQueryContentEvent* aEvent)
761   nsIFrame::ContentOffsets offsets =
762     textframe->GetCharacterOffsetAtFramePoint(ptInTarget);

4909 nsTextFrame::GetCharacterOffsetAtFramePoint(const nsPoint &aPoint)
4911   return GetCharacterOffsetAtFramePointInternal(aPoint, PR_FALSE);

4915 nsTextFrame::GetCharacterOffsetAtFramePointInternal(const nsPoint &aPoint,
4916                                                     PRBool aForInsertionPoint)
4917 {
4918   ContentOffsets offsets;
4919
4920   gfxSkipCharsIterator iter = EnsureTextRun();
4921   if (!mTextRun)
4922     return offsets; 

the caller expected offsets.content to be false, not uninitialized:
763   NS_ENSURE_TRUE(offsets.content, NS_ERROR_FAILURE);
The |content| member of ContentOffsets is an nsCOMPtr.  What's the problem, exactly?
oops. sorry. and i caught the otherone as having that guard.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.