Closed
Bug 550193
Opened 16 years ago
Closed 15 years ago
ec_NewKey calls mp_clear for uninitialized k when SECITEM_CopyItem(...) fails
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.13
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
(Keywords: coverity, Whiteboard: FIPS)
Attachments
(1 file)
|
1.05 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
237 ec_NewKey(ECParams *ecParams, ECPrivateKey **privKey,
238 const unsigned char *privKeyBytes, int privKeyLen)
244 mp_int k;
278 if (ecParams->fieldID.type == ec_field_GFp) {
279 CHECK_SEC_OK(SECITEM_CopyItem(arena, &key->ecParams.fieldID.u.prime,
280 &ecParams->fieldID.u.prime));
328 cleanup:
329 mp_clear(&k);
|
||
Comment 2•15 years ago
|
||
Comment on attachment 431974 [details] [diff] [review]
patch
r=nelson
Attachment #431974 -
Flags: review?(nelson) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: FIPS
Target Milestone: --- → 3.13
|
|
||
Comment 3•15 years ago
|
||
lib/freebl/ec.c; new revision: 1.20.8.2; previous revision: 1.20.8.1
Thanks, Timeless.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•