55022 - Personal toolbar *status* is not migrated correctly when the original profile is created by Japanese Communicator

Status: RESOLVED WONTFIX

(Core Graveyard :: Profile: Migration, defect, P2)

Description

[Koike Kazuhiko]

Personal toolbar with Japanese name can't be migrated.

If a folder name of personal toolbar is Japanese(Default name of
Japanese NC 4.x is 'yuuza settei tuul baa'), it can't be migrated.

This bug was originally reported on Bugzilla-jp.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=157

And it may be related to bug 44764.

Comment 1

[Koike Kazuhiko]

*** Bug 55476 has been marked as a duplicate of this bug. ***

Comment 2

[Koike Kazuhiko]

Forget the previous comment. bug 55476 isn't related to this bug.

Comment 3

[Katsuhiko Momoi]

I'm going to confirm this bug and summarize my findings.
Essentially the problem is as follows.

1. When migrating 4.x profile, the items which show up as icons on the Personal
   Toolbar under 4.x do not show up as icons under the new profile in Mozilla.
    (Confirmed with 10/26/2000 Win32 MN6 build.)
2. For this problem to occur, the original profile must be created by a Japanese
   version of Communicator 4.x. If you create a profile with English version of
   Communicator 4.x, the Personal Toolbar items will show up icons on the Personal
    Toolbar of Mozilla.

3. The problem seems to be due to the following facts:

    a. In the original profile created by Japanese Communicator 4.x, the name
"Personal
        Toolbar" as used in Bookmark.htm and prefs.js files is in Japanese
containing
         multi-byte characters.
    b. For the Personal Toolbar items to show up on the Personal Toolbar for
Mozilla,
       the migrated Bookmark.htm needs to contain a line like the following,

        <DL><p>
        <DT><H3 ADD_DATE="972710981" PERSONAL_TOOLBAR_FOLDER="true"
          ID="NC:PersonalToolbarFolder">Personal Toolbar Folder</H3>
         <DL><p>

     c. When the original prefs.js and Bookmark.htm contain the name of
         "Personal Toolbar" translated into Japanese, the above lines don't
         created in the migrated profile. Instead, something like the following
         get created in the new Bookmark.htm file:

         DL><p>
         <DT><H3 ADD_DATE="972673081"
ID="NC:BookmarksRoot#$903832b9">"Personal_Toolbar_
                 in_Japanse"</H3>
         <DL><p>

      d. When you have lines like those in step C above, the original personal
bar items
          do not show on the Mozilla Personal Toolbar, even though the items are
           migrated and exist in the Bookimark.htm file.

      e. Thus, this is a case of failure to migrate Personal Toolbar status
          properly when the name "Personal Toolbar" is in Japanese. Thererefore
          an issue to be dealt with in Profile Migration.

   (Workaround)

    There is a way to correct this after the fact. 1) Open Bookemark | Manage
Bookmark
     menu item. 2) Select the translated "Personal Toolbar folder". 3. Then by using
      View | Set as Personal Toolbar folder, designate this Japanese name folder
      as the Personal Folder. 4. Quit Mozilla, and re-start. 5. If you do steps 1-4,
      you will see the Personal Folder icons on the Toolbar.

      If you look in the Bookmark.htm file at step 5, you will an entry as described
       above in 3b. So this problem is correctable.

By the way, this problem occurs whether Mozilla is English or Japanese version.

Comment 4

[Katsuhiko Momoi]

Modified the summary line to state the problem more clearly.

Comment 5

[varada]

reassigning bug to bhuvan

Comment 6

[racham]

onto Conrad...

Comment 7

[Conrad Carlen (not reading bugmail)]

Isn't this a migration-specific issue, not a profile back-end issue? Don?

Comment 8

[Conrad Carlen (not reading bugmail)]

To dbragg - I really don't think this is profile mgr.

Comment 9

[dbragg]

Actually it's neither.  We don't mess with the bookmark file in ANY way during
migration.  This is a bookmark file "reader" problem in mozilla which is a
browser bug.  Reassigning to vishy because I don't know who specifically handles
bookmarks in the browser.

Comment 10

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 11

[Viswanath Ramachandran]

reassigning to alec. we will need some help in repruducing this one. not sure if 
it is a nsbeta1+. 

Comment 12

[timeless]

really reassigning

Comment 13

[Paul Chen]

nav triage team:

Marking nsbeta1+ and p2

Comment 14

[Alec Flett]

I don't think I am going to make this for beta, mostly because I have no real
expertise in the area.. if someone in intl wants to take this over, you are more
than welcome :)

Comment 15

[Jaime Rodriguez, Jr.]

I still think this one is needed for beta. It would be a real same not to 
migrate people's information correctly.

FTang - If your team finds some time this week, can they take a look at this 
one?

We should release note it, if it doesn't make it in for M0.9.1

Comment 16

[Jaime Rodriguez, Jr.]

I would consider this data loss, and a beta stopper. People losing their 
information when they migrate, is not a good thing.

Comment 17

[Jaime Rodriguez, Jr.]

Marking as dataloss, nsCatFood and RTM. We should not ship with this bug open.

Assigning P1 per i18n Nav pre-triage.

Comment 18

[Viswanath Ramachandran]

nav+pdt triage: ftang's group will take this. 

Comment 19

[nhottanscp]

Reassign to nhotta, cc to racham and ccarlen, where can I find the bookmark
migration code?

Comment 20

[Conrad Carlen (not reading bugmail)]

See dbragg's comment from 2001-01-10 10:39. The contents of the bookmarks file
are not migrated. The most that happens to the bookmarks file is that is is
renamed. That happens here:
http://lxr.mozilla.org/seamonkey/source/profile/pref-migrator/src/nsPrefMigration.cpp#1784

Comment 21

[nhottanscp]

Well, then we need to write a new code to read the file and write to a new file
with applying a charset conversion to UTF-8 from OS charset.
Conrad, is there similar operation done in the migration code (I mean, modifying
the file content)?

Comment 22

[nhottanscp]

nsBookmarksService.cpp has a charset conversion code.
Not sure why it does not work. Can anybody attach a Japanse 4.x bookmark?

Comment 23

[Kasumi]

Attachment: 4.75 JA bookmark.htm

Comment 24

[nhottanscp]

I tested on my machine (WinNT4 JA), the personal toolbar was migrated but not 
the top level. On Kasumi's machine, she used JA localized build, there Japanese 
named personal toolbar was migrated as a top level personal toolbar. 
So there is no dataloss in any case.

IQA, could you try again NS4.x JA -> NS6.x JA migration? 

About NS4.x JA to NS6.x non JA, japanese personal toolbar cannot be recognized 
as a personal toolbar, this is an expected behavior.

Comment 25

[nhottanscp]

Remove 'dataloss' because the data is not lost, it is copied to a wrong place in 
the bookmark.

Comment 26

[nhottanscp]

jonrubin tested migrating 4.x JA to 6.x JA and personal toolbar items were 
migrated correctly. So it works as long as the source and the target are 
localized in the same language.
jaimejr, please re-evaluate the current keywords (nsbeta1+, nsCatFood+, rtm), 
thanks.

Comment 27

[Jon Rubin]

Note:  I ran my test by migrating from Ja 4.75  -->  Ja 2001-06-04-15-0.9.1

Comment 28

[Frank Tang]

base on nhotta' explaination, I think we can move to moz0.9.3 

Comment 29

[Jaime Rodriguez, Jr.]

Marking nsbeta1-, and nsCatFood-. Removing RTM keyowrd.

Comment 30

[Frank Tang]

move to future

Comment 31

[Andreas Becker]

mass change, switching qa contact from jonrubin to ruixu.

Comment 32

[Thomas]

Does this bug only occur when migrating from Netscape 4.x?

Comment 33

[Matthias Versen [:Matti]]

NS4.x profile migration is gone