Closed
Bug 550223
Opened 14 years ago
Closed 14 years ago
Update nspr/nss actions in client.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file, 1 obsolete file)
991 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I'd like to propose the following additions to client.py and will attach a patch: - when updating NSPR, write the name of the imported tag to file nsprpub/tag-info.txt - when updating NSS, write the name of the imported tag to file security/nss/tag-info.txt - when updating NSS, print a reminder to reapply the local patches on top of the imported tag.
Attachment #430349 -
Flags: review?(benjamin)
Assignee | ||
Comment 1•14 years ago
|
||
FYI, directory security/patches does not yet exist, it's going to be added in bug 527659.
Comment 2•14 years ago
|
||
Kai: adding a file that contains the imported CVS tag is a good idea. I suggest that we name the file in all capital letters so that it'll stand out and be listed first in a directory listing. The reminder to reapply the local patches can be added to our instructions page: https://developer.mozilla.org/en/Updating_NSPR_or_NSS_in_mozilla-central It doesn't need to be added to the client.py script.
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > Kai: adding a file that contains the imported CVS tag is a good > idea. I suggest that we name the file in all capital letters > so that it'll stand out and be listed first in a directory > listing. Then I propose file name TAG-INFO (no suffix). > The reminder to reapply the local patches can be added to our > instructions page: > https://developer.mozilla.org/en/Updating_NSPR_or_NSS_in_mozilla-central > > It doesn't need to be added to the client.py script. Ok, removed from the script.
Attachment #430349 -
Attachment is obsolete: true
Attachment #430527 -
Flags: review?
Attachment #430349 -
Flags: review?(benjamin)
Assignee | ||
Updated•14 years ago
|
Attachment #430527 -
Flags: review? → review?(benjamin)
Updated•14 years ago
|
Attachment #430527 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1ba5ff2c1c45
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
Shouldn't the two TAG-INFO files be committed inside hg to keep directly system a track record of which tag was imported ? They're not on mozilla-central.
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #5) > Shouldn't the two TAG-INFO files be committed inside hg to keep directly system > a track record of which tag was imported ? They're not on mozilla-central. Yes, they will be added the next time we import new revisions of nspr/nss.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•