Update nspr/nss actions in client.py

RESOLVED FIXED

Status

defect
RESOLVED FIXED
9 years ago
Last year

People

(Reporter: kaie, Assigned: kaie)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 years ago
Posted patch Patch v1 (obsolete) — Splinter Review
I'd like to propose the following additions to client.py and will attach a patch:

- when updating NSPR, write the name of the imported tag to file
  nsprpub/tag-info.txt

- when updating NSS, write the name of the imported tag to file
  security/nss/tag-info.txt

- when updating NSS, print a reminder to reapply the local patches
  on top of the imported tag.
Attachment #430349 - Flags: review?(benjamin)
Assignee

Comment 1

9 years ago
FYI, directory security/patches does not yet exist, it's going to be added in bug 527659.

Comment 2

9 years ago
Kai: adding a file that contains the imported CVS tag is a good
idea.  I suggest that we name the file in all capital letters
so that it'll stand out and be listed first in a directory
listing.

The reminder to reapply the local patches can be added to our
instructions page:
https://developer.mozilla.org/en/Updating_NSPR_or_NSS_in_mozilla-central

It doesn't need to be added to the client.py script.
Assignee

Comment 3

9 years ago
Posted patch Patch v2Splinter Review
(In reply to comment #2)
> Kai: adding a file that contains the imported CVS tag is a good
> idea.  I suggest that we name the file in all capital letters
> so that it'll stand out and be listed first in a directory
> listing.

Then I propose file name TAG-INFO (no suffix).

> The reminder to reapply the local patches can be added to our
> instructions page:
> https://developer.mozilla.org/en/Updating_NSPR_or_NSS_in_mozilla-central
> 
> It doesn't need to be added to the client.py script.

Ok, removed from the script.
Attachment #430349 - Attachment is obsolete: true
Attachment #430527 - Flags: review?
Attachment #430349 - Flags: review?(benjamin)
Assignee

Updated

9 years ago
Attachment #430527 - Flags: review? → review?(benjamin)

Updated

9 years ago
Attachment #430527 - Flags: review?(benjamin) → review+
Assignee

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/1ba5ff2c1c45
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Shouldn't the two TAG-INFO files be committed inside hg to keep directly system a track record of which tag was imported ? They're not on mozilla-central.
Assignee

Comment 6

9 years ago
(In reply to comment #5)
> Shouldn't the two TAG-INFO files be committed inside hg to keep directly system
> a track record of which tag was imported ? They're not on mozilla-central.

Yes, they will be added the next time we import new revisions of nspr/nss.

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.