add --enable-debug-symbols to mozconfigs

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We currently have MOZ_DEBUG_SYMBOLS=1 in our mozconfigs to get debug symbols for NSS. bug 517097 is adding --enable-debug-symbols, which uses the same variable internally, so if we land that patch, our current mozconfigs will cause the build system to stick an extra -g in the compile commandline, which will probably screw up the type of debug symbols we want. We should preemptively add --enable-debug-symbols="-gwhatever" to match the CFLAGS/CXXFLAGS stuff we have now, so we can land that patch. Once we also fix NSPR to handle --enable-debug-symbols, we can remove the MOZ_DEBUG_SYMBOLS bit from the mozconfigs.
Created attachment 430389 [details] [diff] [review]
add --enable-debug symbols to all linux and macosx trunk and project branch mozconfigs

I made these changes automatically, using the following two commands:

find . -name "mozconfig" | xargs grep -l MOZ_DEBUG_SYMBOLS | grep -v "1.9" | grep -v lorentz | grep -v "seamonkey/.*/comm-central/" | grep linux | xargs sed -i -e 's/export MOZ_DEBUG_SYMBOLS=1/\0\nac_add_options --enable-debug-symbols="-gstabs+"/'

find . -name "mozconfig" | xargs grep -l MOZ_DEBUG_SYMBOLS | grep -v "1.9" | grep -v lorentz | grep -v "seamonkey/.*/comm-central/" | grep macosx  | xargs sed -i -e 's/export MOZ_DEBUG_SYMBOLS=1/\0\nac_add_options --enable-debug-symbols="-gdwarf-2"/'

The --enable-debug-symbols will be a no-op until we land bug 517097, but without it, landing that bug will screw up our debug symbols for Breakpad.
Attachment #430389 - Flags: review?(catlee)
Status: NEW → ASSIGNED
Attachment #430389 - Flags: review?(bugzilla)
Comment on attachment 430389 [details] [diff] [review]
add --enable-debug symbols to all linux and macosx trunk and project branch mozconfigs

catlee rightly points out that I'm touching SM and TB mozconfigs here as well. Note that the changes were all produced in an automated fashion as described above. I've only changed mozconfigs for branches that track mozilla-central.
Attachment #430389 - Flags: review?(kairo)
Comment on attachment 430389 [details] [diff] [review]
add --enable-debug symbols to all linux and macosx trunk and project branch mozconfigs

The Thunderbird changes look fine to me.
Attachment #430389 - Flags: review?(bugzilla) → review+

Updated

9 years ago
Attachment #430389 - Flags: review?(kairo) → review+

Updated

9 years ago
Attachment #430389 - Flags: review?(catlee) → review+
Comment on attachment 430389 [details] [diff] [review]
add --enable-debug symbols to all linux and macosx trunk and project branch mozconfigs

Pushed to buildbot-configs:
http://hg.mozilla.org/build/buildbot-configs/rev/46a07b960340
Attachment #430389 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 5

9 years ago
umm, should this be backed out as well as bug 517097 has been backed out?
No, this is harmless without that bug, but it's a pre-requisite to landing it.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.