550368 - Syntax errors in modules don't raise tracebacks or line numbers

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

In the Jetpack SDK packaging tutorial, if the code for "add" contains the word "returns" instead of "return", then the response of "cfx test" is:

> Traceback (most recent call last):
> SyntaxError: missing ; before statement
> FAIL
> Total time: 1.018095 seconds
> Program terminated unsuccessfully.

This is terrible feedback! Must make more helpful before 0.1 launch, shouldn't be hard.

Comment 1

[Atul Varma [:atul]]

Discussed this one w/ Myk and it's not a hard blocker for 0.1 launch; adding it as a priority bugfix for 0.1.1 though.

Comment 2

[Atul Varma [:atul]]

Added this to the "known issues" section of 0.1: https://wiki.mozilla.org/Labs/Jetpack/Release_Notes/0.1#Known_Issues

Comment 3

[Atul Varma [:atul]]

Fixed:

  http://hg.mozilla.org/labs/jetpack-sdk/rev/c23377ff1d92

An error like the one in comment 1 now raises this:

> Traceback (most recent call last):
>   File "blah.js", line 25, in null
> SyntaxError: missing ; before statement

However, we still don't get full stack tracebacks, in part because Cu.evalInSandbox--which is called by require()--doesn't include any parts of the stack frame above the current one when it throws errors, probably because it creates a brand new JS context to run the sandboxed code in. Will create a new bug for that, but this fix should be enough to not completely alienate developers for now.

Comment 4

[Atul Varma [:atul]]

Filed the new bug as bug 551604.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".