550371 - mozalloc failed to build on Solaris

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ginn Chen]

Error: std::bad_alloc is not in the current exception specification.

I'm working on it.

Comment 1

[Ginn Chen]

Attachment: patch

matches Sun C++ compiler header file
I'm not sure if it is what we want, it passed compilation.

Comment 2

[Ginn Chen]

Attachment: patch

Need one more change to make it build with Sun Studio 12.
SS12 throws warnings on unsupported attributes, so it passed configure.
When these attributes put together, SS12 failed to work, might be a bug of SS12.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 430496 [details] [diff] [review]
patch

>diff --git a/js/ctypes/tests/Makefile.in b/js/ctypes/tests/Makefile.in
>--- a/js/ctypes/tests/Makefile.in
>+++ b/js/ctypes/tests/Makefile.in
>@@ -48,17 +48,17 @@ LIBRARY_NAME = jsctypes-test
> SHORT_LIBNAME = jscttest
> FORCE_SHARED_LIB = 1
> NO_DIST_INSTALL = 1
> 
> CPPSRCS = jsctypes-test.cpp
> 
> EXTRA_DSO_LDOPTS += \
>     $(XPCOM_STANDALONE_GLUE_LDOPTS) \
>-    $(MOZALLOC_LIB) \
>+    -L$(LIBXUL_DIST)/lib $(MOZALLOC_LIB) \
>     $(NSPR_LIBS) \
>     $(NULL)
> 

This isn't my territory, calling in :bs for review.

I'm OK with the rest, r+ conditional on :bs's.

Comment 4

[Takanori MATSUURA]

I think mozalloc part of fix is not __SUNPRO_CC specific but all compilers if exception handling is enabled.

If "--enable-cpp-exceptions" is set in configure script, we will get same error.

Comment 5

[Takanori MATSUURA]

Attachment: WIP: updated attachment 430496

I suppose this is more generic.

BTW, does SUNPRO_CC always enable exception handling?

Comment 6

[Takanori MATSUURA]

Attachment: WIP: updated attachment 430496

Comment 7

[Takanori MATSUURA]

(In reply to comment #6)
> WIP: updated attachment 430496 [details] [diff] [review]
WIP: updated attachment 431028 [details] [diff] [review].

Comment 8

[Ginn Chen]

Thanks you, Takanori.

I'll update my patch based on yours.

Comment 9

[Ginn Chen]

Attachment: patch v2

add flags to enable/disable c++ except for sun studio compiler.

Comment 10

[Ginn Chen]

Attachment: patch v2 update to head

Comment 11

[Jacek Caban]

Attachment: fix

I had similar problem on mingw. I've attached my patch proposal. It integrates configure with rules.mk so that makefile ENABLE_CXX_EXCEPTIONS is always handled properly. Not tested on Solaris.

Comment 12

[Ginn Chen]

Attachment: patch v3

Combine Jacek's change of rules.mk
BTW: Do we still care VC++ 2003 or earlier?

Put AC_DEFINE(MOZ_CPP_EXCEPTIONS) to the right place.

Comment 13

[Ginn Chen]

Attachment: merge after Bug 441324

Jacek, does it work on mingw?

Comment 14

[Jacek Caban]

Comment on attachment 435113 [details] [diff] [review]
merge after Bug 441324

Yes, it works great, thanks.

Comment 15

[Takanori MATSUURA]

Attachment: merge after bug 538324

After http://hg.mozilla.org/mozilla-central/rev/2ffce4096c56
js/ctypes/tests/Makefile.in is moved to toolkit/components/ctypes/tests/Makefile.in.

Comment 16

[Mitchell Field [:Mitch]]

Comment on attachment 437183 [details] [diff] [review]
merge after bug 538324

>-dnl C++ exceptions (g++/egcs only - for now)
>+dnl C++ exceptions (g++/egcs/VC/irix6/Sun only - for now)

EGCS was a pre-GCC 2.95 fork. Please remove both instances of "egcs".

Comment 17

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/43241b879901

comment 16 addressed.

Comment 18

[[e-mail]]

(In reply to comment #12)
> BTW: Do we still care VC++ 2003 or earlier?
Don't worry, VC++2003 supports -EHsc anyway.