Closed Bug 550388 Opened 10 years ago Closed 10 years ago

fix_macosx_stack is very slow when given a long line of hyphens

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: jruderman)

Details

Attachments

(2 files)

Attached patch patchSplinter Review
The regexp
  ^([ \|0-9-]*)(.*) ?\[...
is very slow.

I'm guessing this is due to regexp backtracking.  It's slow enough that my scripts think Firefox is hanging when it's not.

Here's one possible fix.  It seems to fix the perf issue, and balance trees still look good.
Attachment #430501 - Flags: review?(dbaron)
Attached file testing script
Comment on attachment 430501 [details] [diff] [review]
patch

r=dbaron
Attachment #430501 - Flags: review?(dbaron) → review+
Assignee: nobody → jruderman
http://hg.mozilla.org/mozilla-central/rev/659d517acd61
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.