op_filok nspr test fails on Windows Mobile

RESOLVED FIXED in 4.8.5

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: alexp, Assigned: alexp)

Tracking

other
4.8.5
ARM
Windows Mobile 6 Professional

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The test is looking for a file, which does not exist on WM.
(Assignee)

Comment 1

9 years ago
Created attachment 430525 [details] [diff] [review]
Use the file, which exists on a WinCE system
Attachment #430525 - Flags: review?(bugmail)
Attachment #430525 - Flags: review?(wtc)
Attachment #430525 - Flags: review?(bugmail)
Attachment #430525 - Flags: review+
(Assignee)

Updated

9 years ago
Assignee: wtc → alexp

Comment 2

9 years ago
Comment on attachment 430525 [details] [diff] [review]
Use the file, which exists on a WinCE system

r=wtc.

>+#elif defined(WINCE)
>+#define EXISTING_FILENAME "/Windows/services.exe"

Do we not need a drive letter for this pathname?
Attachment #430525 - Flags: review?(wtc) → review+
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> >+#define EXISTING_FILENAME "/Windows/services.exe"
> 
> Do we not need a drive letter for this pathname?

Nope.
WinCE doesn't have those.
its like *nix. The root fs is \, storage cards are mounted as subfolders like \My Storage or \Storage Card.
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

9 years ago
Keywords: checkin-needed

Comment 5

9 years ago
Thanks.  I checked in the patch on the NSPR trunk (NSPR 4.8.5).

Checking in op_filok.c;
/cvsroot/mozilla/nsprpub/pr/tests/op_filok.c,v  <--  op_filok.c
new revision: 3.16; previous revision: 3.15
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.8.5
what is checkin-needed here?

Comment 7

9 years ago
I didn't notice the checkin-needed keyword when I checked in the patch.
It's now removed.
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.