[dashboard][shipping] pushes view busted for non-open milestones

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

8 years ago
https://l10n-stage-sj.mozilla.org/shipping/pushes?locale=ga-IE&av=tb3.1 is busted now that tb3.1 has no open milestone.

I see two things, firstly the signoff is retrieved from the milestone and not the appversion. The other is that ms.signoffs.get(locale=locale) doesn't have an exception handling for non-existing locales.
(Assignee)

Comment 1

8 years ago
Taking. Not sure if I should touch the ms vs av stuff.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/l10n/django-site/rev/6671dd4975c4, just added the exception handling.

The rest of the pushes view needs some cleanup and we'll need to throw a dice on whether to really remove the ms param code path or not. I'm tempted to do so.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.