The default bug view has changed. See this FAQ.

[PageInfo] Sync changes from mozilla-central

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Page Info
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

10.11 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Port relevant patches from minefield pageInfo.

[Bug 494808] Page Info > Media doesn't list background images anymore.
[Bug 519390] Page info sometimes resizes an image incorrectly when it uses scaling.
[Bug 525190] Refactor the way pageInfo.js handles arguments.
[Bug 523047] Slow selectors in browser css)

I didn't bother with patches that dealt with the fallout from removing metadata.xul (because the code there was confusing and unmaintainable). And then repurposing PageInfo as a faux "View Image Properties". This mashup resulting in confusing and unnecessarily convoluted code (and they are /still/ at it).
(Assignee)

Comment 1

7 years ago
Created attachment 430614 [details] [diff] [review]
Patch v1.0 proposed patch.

Time to ask for initial review.
Attachment #430614 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 430614 [details] [diff] [review]
Patch v1.0 proposed patch.

>-/*
>-richlistitem[feed]:not([selected="true"]) .feed-subscribe {
>-  display: none;
I was thinking, "why this change", and then, "why was it commented out?"...
(It appeared (without comment!) between 379183-6b.diff and 379183-7.diff)

>+  // check for background images, any node may have multiple
>+  var computedStyle = elem.ownerDocument.defaultView.getComputedStyle(elem, "");
>+  if (computedStyle) {
>+    Array.forEach(computedStyle.getPropertyCSSValue("background-image"), function (url) {
>+      if (url.primitiveType == CSSPrimitiveValue.CSS_URI)
>+        addImage(url.getStringValue(), gStrings.mediaBGImg, gStrings.notSet, elem, true);
>+    });
>+  }
This seems familiar, it seems my tree already had this change ;-)
Attachment #430614 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 430614 [details] [diff] [review]
Patch v1.0 proposed patch.

UI touched so asking for sr.

> I was thinking, "why this change", and then, "why was it commented out?"...
> (It appeared (without comment!) between 379183-6b.diff and 379183-7.diff)
Yeah I tracked this down as well. Since there was no comment and Firefox doesn't have this and nobody has complained I thought it was time to rm.
Attachment #430614 - Flags: superreview?(neil)

Updated

7 years ago
Attachment #430614 - Flags: superreview?(neil) → superreview-

Comment 4

7 years ago
(In reply to comment #3)
> Firefox doesn't have this
Actually, it does have it (uncommented)
(Assignee)

Comment 5

7 years ago
So enable it or just leave it uncommented?

Comment 6

7 years ago
Comment on attachment 430614 [details] [diff] [review]
Patch v1.0 proposed patch.

Sorry, click failure on my part.
Attachment #430614 - Flags: superreview- → superreview+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Comment 7

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/01b7cede7010
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.