Closed Bug 550523 Opened 10 years ago Closed 10 years ago

Add fast path to bypass upcall_require on crate cache hit.

Categories

(Servo Graveyard :: Rust, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: graydon, Assigned: graydon)

Details

Followup to bug 548169: we always do one upcall_import to access the crate-cache, even though on a cache hit the upcall is not doing anything more complex than a couple indexed-load-and-compare checks and a return. 

This is not necessary: we can emit those load/compare checks as a fast(er) hit path that stays in the stub, and only upcall on miss.

Deferring for now because it's still not a big cost at the moment, and there's more work to do around the stubs anyways in terms of refcounting (see bug 550522).
Summary: Add fast path to bypass upcall_import on crate cache hit. → Add fast path to bypass upcall_require on crate cache hit.
Moved to github issue #12.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INCOMPLETE
Group: servo
You need to log in before you can comment on or make changes to this bug.