550534 - Mozmill confused if the first id in install.rdf isn't extension's

Status: VERIFIED FIXED

(Testing :: Mozbase, defect)

Description

[Merike Sell (:merike)]

Attachment: Example install.rdf

In the case of Lightning addon extension's id is the last of id-s, the first one is for Thunderbird. When commandline mozmill is run such that Lightning is to be installed it puts it into folder {3550f703-e582-4d05-9a08-453d09bdfdc6} and not into {e2fda1a4-762b-4020-b5ad-a41df1933103}. Thus Thunderbird doesn't load it at all.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like we still have a problem with that detection.

Comment 2

[Jonathan Griffin (:jgriffin)]

I added some more code to handle this case, and sent a pull request to Mikeal:

http://github.com/jonallengriffin/mozrunner/commit/1d0ffdfb3202fcb3d17d5345387d54498378e0f8

The problem was that the code was picking up the first id in the rdf.  In some caes, such as Lightning, the target application's id appears first in the rdf, before the extension id.  With this change, we remove targetApplication elements before looking for the id.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: mozrunner patch

Whimboo requests your review on this, Clint, and says he'll merge it if you approve.  See comment #2 for explanation of patch.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: mozrunner patch v0.2

Oops, the previous patch compared the commits in the wrong order.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)
> Created an attachment (id=433222) [details]
> mozrunner patch v0.2
> 
> Oops, the previous patch compared the commits in the wrong order.

Next time you can simply link to the github patch. that's easier. :)

Comment 6

[Jonathan Griffin (:jgriffin)]

Merged into mikeal's master:

http://github.com/mikeal/mozrunner/commit/1d0ffdfb3202fcb3d17d5345387d54498378e0f8

Comment 7

[Merike Sell (:merike)]

Works great with http://people.mozilla.org/~ctalbert/mozmill_1.4.1/mozrunner-2.4.1-py2.6.egg

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks for the verification Merike!