Mozmill confused if the first id in install.rdf isn't extension's

VERIFIED FIXED

Status

Testing
Mozbase
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: merike, Assigned: jgriffin)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [verified-mozmill-1.4.1])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Created attachment 430681 [details]
Example install.rdf

In the case of Lightning addon extension's id is the last of id-s, the first one is for Thunderbird. When commandline mozmill is run such that Lightning is to be installed it puts it into folder {3550f703-e582-4d05-9a08-453d09bdfdc6} and not into {e2fda1a4-762b-4020-b5ad-a41df1933103}. Thus Thunderbird doesn't load it at all.
Looks like we still have a problem with that detection.
Component: Mozmill → MozRunner
QA Contact: mozmill → mozrunner
Whiteboard: [MozMillAddonTestday]
(Assignee)

Comment 2

8 years ago
I added some more code to handle this case, and sent a pull request to Mikeal:

http://github.com/jonallengriffin/mozrunner/commit/1d0ffdfb3202fcb3d17d5345387d54498378e0f8

The problem was that the code was picking up the first id in the rdf.  In some caes, such as Lightning, the target application's id appears first in the rdf, before the extension id.  With this change, we remove targetApplication elements before looking for the id.
(Assignee)

Updated

8 years ago
Assignee: nobody → jgriffin
(Assignee)

Updated

8 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

8 years ago
Created attachment 433220 [details] [diff] [review]
mozrunner patch

Whimboo requests your review on this, Clint, and says he'll merge it if you approve.  See comment #2 for explanation of patch.
Attachment #433220 - Flags: review?(ctalbert)
(Assignee)

Comment 4

8 years ago
Created attachment 433222 [details] [diff] [review]
mozrunner patch v0.2

Oops, the previous patch compared the commits in the wrong order.
Attachment #433220 - Attachment is obsolete: true
Attachment #433222 - Flags: review?(ctalbert)
Attachment #433220 - Flags: review?(ctalbert)
(In reply to comment #4)
> Created an attachment (id=433222) [details]
> mozrunner patch v0.2
> 
> Oops, the previous patch compared the commits in the wrong order.

Next time you can simply link to the github patch. that's easier. :)

Updated

8 years ago
Attachment #433222 - Flags: review?(ctalbert) → review+
(Assignee)

Comment 6

8 years ago
Merged into mikeal's master:

http://github.com/mikeal/mozrunner/commit/1d0ffdfb3202fcb3d17d5345387d54498378e0f8
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [MozMillAddonTestday] → [mozmill-1.4.1]
(Reporter)

Comment 7

8 years ago
Works great with http://people.mozilla.org/~ctalbert/mozmill_1.4.1/mozrunner-2.4.1-py2.6.egg
Status: RESOLVED → VERIFIED
Thanks for the verification Merike!
Whiteboard: [mozmill-1.4.1] → [verified-mozmill-1.4.1]
You need to log in before you can comment on or make changes to this bug.