Closed
Bug 550539
Opened 14 years ago
Closed 14 years ago
Error in dialog's postLoadInit
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | .7-fixed |
People
(Reporter: toddsf, Assigned: enndeakin)
References
Details
Attachments
(2 files)
|
2.73 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
|
2.73 KB,
patch
|
christian
:
approval1.9.2.4-
dveditz
:
approval1.9.2.7+
|
Details | Diff | Splinter Review |
See this recent change: http://hg.mozilla.org/releases/mozilla-1.9.2/diff/812c49feab66/toolkit/content/widgets/dialog.xml The previous version included (at line 1.9 in the diff) a check to ensure that focusedElt is non-null. That check was removed and thus, if focusedElt is undefined coming into the function or through iterations of the while loop, the while loop fails with a bad reference to focusedElt.localName.
|
Assignee | |
Comment 2•14 years ago
|
||
Looks like this was caused by a manual merging.
|
||
Comment 3•14 years ago
|
||
Comment on attachment 438080 [details] [diff] [review] fix >+ #ifndef XP_MACOSX >+ #endif Trunk doesn't have these spaces before the #s ;-)
Attachment #438080 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #439009 -
Flags: approval1.9.2.4?
Comment on attachment 439009 [details] [diff] [review] remove extra spaces a=LegNeato for 1.9.2.5. Please *only* land it on mozilla-1.9.2 default, as we are still working on the 3.6.4 relbranch and do not want this landed there
Attachment #439009 -
Flags: approval1.9.2.5+
Attachment #439009 -
Flags: approval1.9.2.4?
Attachment #439009 -
Flags: approval1.9.2.4-
|
|
Assignee | |
Updated•14 years ago
|
|
||
Updated•14 years ago
|
Attachment #439009 -
Flags: approval1.9.2.5+ → approval1.9.2.6+
You need to log in
before you can comment on or make changes to this bug.
Description
•