Closed Bug 550542 Opened 10 years ago Closed 10 years ago

[OS/2] follow-ups for xmalloc

Categories

(Core :: XPCOM, defect, major)

x86
OS/2
defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla1.9.3a3

People

(Reporter: wuno, Assigned: wuno)

References

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a3pre) Gecko/20100305 Minefield/3.7a3pre
Build Identifier: 

We need to have $(LIBXUL_DIST)/lib/mozalloc.lib to DYNAMIC_XPCOM_LIBS and LIBXUL_LIBS in the os2 section of configure for linking and the declaration of strndup used by mozmalloc.cpp is hidden behind a __USE_GNU macro in string.h. Either we add _GNU_SOURCE to the Makefile or add __USE_GNU directly in mozmalloc.cpp _before_ the include string.h line. The supposed patch will use the change in the Makefile.

Reproducible: Always
Blocks: 441324
Version: unspecified → Trunk
Attached patch patchSplinter Review
Assignee: nobody → wuno
Status: NEW → ASSIGNED
Attachment #430695 - Flags: review?(jones.chris.g)
Attachment #430695 - Flags: review?(jones.chris.g) → review+
Keywords: checkin-needed
Whiteboard: att 430719 NPOTB all in ifdef XP_OS2
http://hg.mozilla.org/mozilla-central/rev/9c1946147600
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a3
Status: RESOLVED → VERIFIED
Whiteboard: att 430719 NPOTB all in ifdef XP_OS2
You need to log in before you can comment on or make changes to this bug.