550618 - XML-RPC WebService returning wrong dateTime format

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Max Kanat-Alexander]

I forgot that the XML-RPC Specification requires that we send back something that really has nothing to do with ISO-8601: 19980717T14:08:55.

Comment 1

[Max Kanat-Alexander]

  Okay, well, it's not *nothing to do* with ISO-8601, but it's the less-commonly-used format. In any case, we have to fix it. :-|

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, this fixes it. It's mostly just some re-architecture and then replacing the hyphens in the base implementation with nothing.

Comment 3

[Justin Wood (:Callek)]

...sorry :(

Comment 4

[Max Kanat-Alexander]

  dkl: This is currently my only blocker on the 3.6rc1 release, so a speedy review would be appreciated.

Comment 5

[Frédéric Buclin]

Is this bug responsible for http://landfill.bugzilla.org/bugzillaqa/show_bug.cgi?id=3171 ?

Comment 6

[Max Kanat-Alexander]

(In reply to comment #5)
> Is this bug responsible for
> http://landfill.bugzilla.org/bugzillaqa/show_bug.cgi?id=3171 ?

  Yes.

Comment 7

[David Lawrence [:dkl]]

Comment on attachment 430764 [details] [diff] [review]
v1

Code looks good and returns proper date formats in my testing. r=dkl

Comment 8

[David Lawrence [:dkl]]

Should this also be approved for 3.4?

Comment 9

[Justin Wood (:Callek)]

(In reply to comment #8)
> Should this also be approved for 3.4?

No, this is a regression from a patch I landed on 3.6, 3.4 should be good.

Comment 10

[Max Kanat-Alexander]

  Thank you for the fast review, dkl! I know that it's the weekend, so I really appreciate it.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/WebService.pm
modified Bugzilla/WebService/Server.pm
Committed revision 7057. 

modified Bugzilla/WebService.pm
modified Bugzilla/WebService/Server.pm
Committed revision 7024.