550649 - mozilla/configure.in option 'with-qtdir' is very wrong

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

The current tests do not reset MOZ_QT_CFLAGS or MOZ_QT_LIBS when with-qtdir is passed.  The result is that the result of PKG_CHECK_MODULES is always used.  What we want is for with-qtdir to override any default installation of Qt.

Comment 1

[Doug Turner (:dougt)]

The message should read:

No acceptable moc preprocessor found. Qt SDK is not installed or --with-qt is incorrect

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 430799 [details] [diff] [review]
patch v.1

It would probably be nice to at least test that $QTDIR exists if provided.

Comment 3

[Doug Turner (:dougt)]

I was thinking that the test for HOST_MOC, which depends on having a valid $QTDIR, would fail and we would rely on that error message to point developers at what was wrong.  Let me know if you disagree.

http://hg.mozilla.org/mozilla-central/rev/c4aafa6695fe

Comment 4

[(not currently active) Ted Mielczarek]

As long as the error message clearly states what's wrong and how to fix it, that's fine.

Comment 5

[Doug Turner (:dougt)]

cool.  configure will bitch with

No acceptable moc preprocessor found. Qt SDK is not installed or --with-qt is incorrect.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Restore QTDIR support, copy (the useful part of) this bug and bug 552446 follow-up.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 435295 [details] [diff] [review]
(Bv1-CC) Restore QTDIR support, copy (the useful part of) this bug and bug 552446 follow-up.

#1: Please spinoff to new bug.
#2: If we are restoring this arg, lets restore it right and copy the full (current) 1.9.2 syntax and the current trunk syntax (include rules.mk GARBAGE).

Thanks.