Closed Bug 550649 Opened 10 years ago Closed 10 years ago

mozilla/configure.in option 'with-qtdir' is very wrong

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a3

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(2 files)

Attached patch patch v.1Splinter Review
The current tests do not reset MOZ_QT_CFLAGS or MOZ_QT_LIBS when with-qtdir is passed.  The result is that the result of PKG_CHECK_MODULES is always used.  What we want is for with-qtdir to override any default installation of Qt.
Attachment #430799 - Attachment is patch: true
Attachment #430799 - Attachment mime type: application/octet-stream → text/plain
Attachment #430799 - Flags: review?(ted.mielczarek)
Assignee: nobody → dougt
The message should read:

No acceptable moc preprocessor found. Qt SDK is not installed or --with-qt is incorrect
Comment on attachment 430799 [details] [diff] [review]
patch v.1

It would probably be nice to at least test that $QTDIR exists if provided.
Attachment #430799 - Flags: review?(ted.mielczarek) → review+
I was thinking that the test for HOST_MOC, which depends on having a valid $QTDIR, would fail and we would rely on that error message to point developers at what was wrong.  Let me know if you disagree.

http://hg.mozilla.org/mozilla-central/rev/c4aafa6695fe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
As long as the error message clearly states what's wrong and how to fix it, that's fine.
cool.  configure will bitch with

No acceptable moc preprocessor found. Qt SDK is not installed or --with-qt is incorrect.
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a3
Version: unspecified → Trunk
Depends on: 552446
Comment on attachment 435295 [details] [diff] [review]
(Bv1-CC) Restore QTDIR support, copy (the useful part of) this bug and bug 552446 follow-up.

#1: Please spinoff to new bug.
#2: If we are restoring this arg, lets restore it right and copy the full (current) 1.9.2 syntax and the current trunk syntax (include rules.mk GARBAGE).

Thanks.
Attachment #435295 - Flags: review?(bugspam.Callek) → review-
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.