When nsMenu::AttributeChanged bails with the test if((mMacMenuID <= 5) && (mMacMenuID >= 2)) it fails to return a value. Here's the fix: Index: mozilla/widget/src/mac/nsMenu.cpp =================================================================== RCS file: /cvsroot/mozilla/widget/src/mac/nsMenu.cpp,v retrieving revision 1.85 diff -b -c -2 -r1.85 nsMenu.cpp *** nsMenu.cpp 2000/09/22 06:03:08 1.85 --- nsMenu.cpp 2000/10/03 19:42:00 *************** *** 1487,1491 **** if((mMacMenuID <= 5) && (mMacMenuID >= 2)) ! return; ::DeleteMenu(mMacMenuID); --- 1487,1491 ---- if((mMacMenuID <= 5) && (mMacMenuID >= 2)) ! return NS_OK; ::DeleteMenu(mMacMenuID);
Nominate for RTM. Trivial fix, could fix some unknown menu handling errors.
Whiteboard: fix in hand
Target Milestone: --- → M19
rtm-, helpwanted, future
Whiteboard: fix in hand → [rtm-] fix in hand
Target Milestone: M19 → Future
Huh? this is such a trivial change, all I need is sr=saari, and it's in.
The change is fine with me, I'm just not allowed to check it in <shrug> Don't kill me, I didn't make the rules.
saari: put a sr= here, and we'll try again.
rtm++, pretty please?
Whiteboard: [rtm-] fix in hand
Changing to rtm double plus. Don't these items show up in warnings... or are we overloaded on that front these days?
Fix checked in on trunk and branch.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Yes, this did show up as a warning.
verified fixed on branch and trunk by virtue of my friend, Bonsai.
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.