nsMenu::AttributeChanged fails to return a value

VERIFIED FIXED in Future

Status

()

Core
XUL
P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: Simon Fraser, Assigned: saari (gone))

Tracking

({helpwanted})

Trunk
Future
PowerPC
Mac System 8.5
helpwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rtm++])

(Reporter)

Description

18 years ago
When nsMenu::AttributeChanged bails with the test
  if((mMacMenuID <= 5) && (mMacMenuID >= 2))

it fails to return a value. Here's the fix:

Index: mozilla/widget/src/mac/nsMenu.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsMenu.cpp,v
retrieving revision 1.85
diff -b -c -2 -r1.85 nsMenu.cpp
*** nsMenu.cpp	2000/09/22 06:03:08	1.85
--- nsMenu.cpp	2000/10/03 19:42:00
***************
*** 1487,1491 ****
  
      if((mMacMenuID <= 5) && (mMacMenuID >= 2)) 
!       return;
      
      ::DeleteMenu(mMacMenuID);
--- 1487,1491 ----
  
      if((mMacMenuID <= 5) && (mMacMenuID >= 2)) 
!       return NS_OK;
      
      ::DeleteMenu(mMacMenuID);
(Reporter)

Comment 1

18 years ago
Nominate for RTM. Trivial fix, could fix some unknown menu handling errors.
Keywords: rtm
Whiteboard: fix in hand

Comment 2

18 years ago
r=brade
Target Milestone: --- → M19

Comment 3

18 years ago
rtm-, helpwanted, future
Keywords: helpwanted
Whiteboard: fix in hand → [rtm-] fix in hand
Target Milestone: M19 → Future
(Reporter)

Comment 4

18 years ago
Huh? this is such a trivial change, all I need is sr=saari, and it's in.
(Assignee)

Comment 5

18 years ago
The change is fine with me, I'm just not allowed to check it in <shrug> Don't
kill me, I didn't make the rules.
(Reporter)

Comment 6

18 years ago
saari: put a sr= here, and we'll try again.
(Assignee)

Comment 7

18 years ago
yeah, sr=saari
(Reporter)

Comment 8

18 years ago
rtm++, pretty please?
Whiteboard: [rtm-] fix in hand

Comment 9

18 years ago
Changing to rtm double plus.

Don't these items show up in warnings... or are we overloaded on that front
these days?
Whiteboard: [rtm++]
(Reporter)

Comment 10

18 years ago
Fix checked in on trunk and branch.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

18 years ago
Yes, this did show up as a warning.

Comment 12

18 years ago
verified fixed on branch and trunk by virtue of my friend, Bonsai.
Status: RESOLVED → VERIFIED

Updated

10 years ago
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.