Closed Bug 550876 Opened 12 years ago Closed 12 years ago

Backport eventHorizon, changeHorizon code to buildbot 0.7.10

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: catlee)

References

Details

(Whiteboard: [buildmasters])

Attachments

(3 files)

One major reason the current version of buildbot is so slow is that we accumlate thousands of events in the builders.  Every time a slave disconnects and reconnects, 2 events are logged in each builder that slave is attached to.  These events are stored in memory, and must be saved to and loaded from disk on a reconfig.  There's nothing in buildbot 0.7.10 to get rid of them, so they persist until the end of time.

The code to limit the # of events is pretty simple, and applies cleanly to our code base.  I've attached the patch against BUILDBOT_PRODUCTION.  This only needs deploying on the masters.
Attachment #431097 - Flags: review?(bhearsum)
Attachment #431275 - Flags: review?(bhearsum)
Attachment #431276 - Flags: review?(bhearsum)
Summary: Backport eventHorizon code to buildbot 0.7.10 → Backport eventHorizon, changeHorizon code to buildbot 0.7.10
Attachment #431097 - Flags: review?(bhearsum) → review+
Attachment #431275 - Flags: review?(bhearsum) → review+
Attachment #431276 - Flags: review?(bhearsum) → review+
Blocks: 551205
Comment on attachment 431097 [details] [diff] [review]
Limit the number of events to 50 per builder

changeset:   63:e3f8db2dd3f9
Attachment #431097 - Flags: checked-in+
Comment on attachment 431275 [details] [diff] [review]
Backport changeHorizon too

changeset:   64:002370ef5a45
Attachment #431275 - Flags: checked-in+
Comment on attachment 431276 [details] [diff] [review]
Set changeHorizon to 100 on selected masters

changeset:   2146:fe9a5aa5837f
Attachment #431276 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.