Closed
Bug 550876
Opened 14 years ago
Closed 14 years ago
Backport eventHorizon, changeHorizon code to buildbot 0.7.10
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: catlee)
References
Details
(Whiteboard: [buildmasters])
Attachments
(3 files)
2.49 KB,
patch
|
bhearsum
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
4.71 KB,
patch
|
bhearsum
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
2.34 KB,
patch
|
bhearsum
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
One major reason the current version of buildbot is so slow is that we accumlate thousands of events in the builders. Every time a slave disconnects and reconnects, 2 events are logged in each builder that slave is attached to. These events are stored in memory, and must be saved to and loaded from disk on a reconfig. There's nothing in buildbot 0.7.10 to get rid of them, so they persist until the end of time. The code to limit the # of events is pretty simple, and applies cleanly to our code base. I've attached the patch against BUILDBOT_PRODUCTION. This only needs deploying on the masters.
Attachment #431097 -
Flags: review?(bhearsum)
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #431275 -
Flags: review?(bhearsum)
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #431276 -
Flags: review?(bhearsum)
Assignee | ||
Updated•14 years ago
|
Summary: Backport eventHorizon code to buildbot 0.7.10 → Backport eventHorizon, changeHorizon code to buildbot 0.7.10
Updated•14 years ago
|
Attachment #431097 -
Flags: review?(bhearsum) → review+
Updated•14 years ago
|
Attachment #431275 -
Flags: review?(bhearsum) → review+
Updated•14 years ago
|
Attachment #431276 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 431097 [details] [diff] [review] Limit the number of events to 50 per builder changeset: 63:e3f8db2dd3f9
Attachment #431097 -
Flags: checked-in+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 431275 [details] [diff] [review] Backport changeHorizon too changeset: 64:002370ef5a45
Attachment #431275 -
Flags: checked-in+
Assignee | ||
Comment 5•14 years ago
|
||
Comment on attachment 431276 [details] [diff] [review] Set changeHorizon to 100 on selected masters changeset: 2146:fe9a5aa5837f
Attachment #431276 -
Flags: checked-in+
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•