Open Bug 550915 Opened 10 years ago Updated 2 years ago

unreachable code in cairo_scaled_font_glyph_extents

Categories

(Core :: Graphics, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

()

ASSIGNED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

1.29 KB, patch
timeless
: review?
jrmuizel
Details | Diff | Splinter Review
1413 cairo_scaled_font_glyph_extents (cairo_scaled_font_t   *scaled_font,

1434     if (num_glyphs == 0)
1435         return;

1437     if (num_glyphs < 0) {
1440         return;

after this point, num_glyphs > 0

1498     if (num_glyphs) {
1510     } else {

so this is unreachable:
1511         extents->x_advance = 0.0;
1512         extents->y_advance = 0.0;
1513     }
Attached patch proposalSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #431166 - Flags: review?(vladimir)
Attachment #431166 - Flags: review?(vladimir) → review?(jmuizelaar)
ping
You need to log in before you can comment on or make changes to this bug.