Closed Bug 550942 Opened 10 years ago Closed 10 years ago

Hunspell::get_xml_list doesn't handle failure from get_xml_par

Categories

(Core :: Spelling checker, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file, 1 obsolete file)

1686 int Hunspell::get_xml_list(char ***slst, char * list, const char * tag) {

1694     for (p = list, n = 0; (p = strstr(p, tag)); p++, n++) {

1698         get_xml_par((*slst)[n], p + strlen(tag) - 1, l);

1701 }

According to coverity, all other callers do.
Attached patch proposal (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #431162 - Flags: review?(ryanvm)
Comment on attachment 431162 [details] [diff] [review]
proposal

timeless, I'm not a spellcheck peer. I'm moving the review over to Nemeth for review, but it ultimately may need a Mozillian to review. I think smaug has reviewed some spellcheck stuff since the departure of mscott.
Attachment #431162 - Flags: review?(ryanvm) → review?(nemeth)
Fixed by bug 564608
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #431162 - Attachment is obsolete: true
Attachment #431162 - Flags: review?(nemeth)
You need to log in before you can comment on or make changes to this bug.