Closed
Bug 550942
Opened 14 years ago
Closed 14 years ago
Hunspell::get_xml_list doesn't handle failure from get_xml_par
Categories
(Core :: Spelling checker, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
699 bytes,
patch
|
Details | Diff | Splinter Review |
1686 int Hunspell::get_xml_list(char ***slst, char * list, const char * tag) {
1694 for (p = list, n = 0; (p = strstr(p, tag)); p++, n++) {
1698 get_xml_par((*slst)[n], p + strlen(tag) - 1, l);
1701 }
According to coverity, all other callers do.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 431162 [details] [diff] [review] proposal timeless, I'm not a spellcheck peer. I'm moving the review over to Nemeth for review, but it ultimately may need a Mozillian to review. I think smaug has reviewed some spellcheck stuff since the departure of mscott.
Attachment #431162 -
Flags: review?(ryanvm) → review?(nemeth)
|
||
Comment 3•14 years ago
|
||
|
|
||
Comment 4•14 years ago
|
||
Fixed by bug 564608
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Attachment #431162 -
Attachment is obsolete: true
Attachment #431162 -
Flags: review?(nemeth)
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•