550962 - add coverity hint in CSSParserImpl to ignore return values from ParseEnum/ExpectSymbol

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[timeless]

zwol indicates that these are intentional but that he'd be ok w/ adding (void) for them.

6815 CSSParserImpl::ParseBorderImage()
6884   if (ParseEnum(horizontalKeyword, nsCSSProps::kBorderImageKTable)) {
6885     ParseEnum(verticalKeyword, nsCSSProps::kBorderImageKTable);

7134 CSSParserImpl::DoParseRect(nsCSSRect& aRect)
7171       if (3 != side) {
7172         // skip optional commas between elements
7173         ExpectSymbol(',', PR_TRUE);

Comment 1

[Zack Weinberg (:zwol)]

dbaron, do you have an opinion?

Comment 2

[timeless]

Attachment: proposal

timeless-mbp:mozilla-central timeless$ grep '(void)' layout/style/nsComputedDOMStyle.cpp
  (void)GetQueryablePropertyMap(aLength);

So, this matches that style.

Comment 3

[Zack Weinberg (:zwol)]

Comment on attachment 431164 [details] [diff] [review]
proposal

This changes ParseBorderImage and DoParseRect.  Weren't you going to change ParseDasharray?

(FWIW, this appears to be a correct change in DoParseRect as well.)

Comment 4

[timeless]

Attachment: proposal

Comment 5

[timeless]

Attachment: proposal

Comment 6

[Zack Weinberg (:zwol)]

Comment on attachment 431210 [details] [diff] [review]
proposal

Looks good.

>@@ -9084,7 +9084,7 @@ CSSParserImpl::ParseDasharray()
>         break;
> 
>        // skip optional commas between elements
>-      ExpectSymbol(',', PR_TRUE);
>+      (void)ExpectSymbol(',', PR_TRUE);
> 
>       if (!ParseVariant(value,
>                         VARIANT_LENGTH | VARIANT_PERCENT | VARIANT_NUMBER,

Would you mind fixing the indentation of the comment here, as long as you're in the file?  (It should be aligned with the code, not one space further in.)

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 431210 [details] [diff] [review]
proposal

looks ok to me

Comment 8

[timeless]

Attachment: align comment

Comment 9

[timeless]

http://hg.mozilla.org/mozilla-central/rev/e2eca12381c4