Closed Bug 551049 Opened 11 years ago Closed 11 years ago

Deliver stream data asynchronously

Categories

(Core :: Plug-ins, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

Currently we do a lot of round-tripping sending data between the browser and plugins: each write cycle is two round-trips, one for NPP_WriteReady and one for NPP_Write.

I started to deliver this data asynchronously in but 532208 and want to finish it here. The patch queue is this:

* the test/patch from bug 550944
* back out http://hg.mozilla.org/mozilla-central/rev/f829f942873d
* https://bugzilla.mozilla.org/attachment.cgi?id=428662 from bug 532208
* https://bugzilla.mozilla.org/attachment.cgi?id=428982 from bug 532208
* Delay-NPP_URLNotify which I'll attach here shortly
Depends on: 550944
Comment on attachment 431235 [details] [diff] [review]
part 3: Delay NPP_URLNotify, cancel streams when the instance is torn down, rev. 1

>+        // reclaim responsibility for deleting ourself
>+        mBrowserStream = NULL;
>+        mBrowserStream->mStreamNotify = NULL;

That looks like it will crash ;)

r=me with that!
Attachment #431235 - Flags: review?(bent.mozilla) → review+
Depends on: 551773
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 563361
You need to log in before you can comment on or make changes to this bug.