Closed Bug 551049 Opened 11 years ago Closed 11 years ago
Deliver stream data asynchronously
Currently we do a lot of round-tripping sending data between the browser and plugins: each write cycle is two round-trips, one for NPP_WriteReady and one for NPP_Write. I started to deliver this data asynchronously in but 532208 and want to finish it here. The patch queue is this: * the test/patch from bug 550944 * back out http://hg.mozilla.org/mozilla-central/rev/f829f942873d * https://bugzilla.mozilla.org/attachment.cgi?id=428662 from bug 532208 * https://bugzilla.mozilla.org/attachment.cgi?id=428982 from bug 532208 * Delay-NPP_URLNotify which I'll attach here shortly
Comment on attachment 431235 [details] [diff] [review] part 3: Delay NPP_URLNotify, cancel streams when the instance is torn down, rev. 1 >+ // reclaim responsibility for deleting ourself >+ mBrowserStream = NULL; >+ mBrowserStream->mStreamNotify = NULL; That looks like it will crash ;) r=me with that!
Attachment #431235 - Flags: review?(bent.mozilla) → review+
http://hg.mozilla.org/mozilla-central/rev/6d13458be1b0 http://hg.mozilla.org/mozilla-central/rev/b594d5b63dd0 http://hg.mozilla.org/mozilla-central/rev/d5aa9bd8864d http://hg.mozilla.org/mozilla-central/rev/beed4bc507c9 http://hg.mozilla.org/mozilla-central/rev/dc3af645f713 followup, http://hg.mozilla.org/mozilla-central/rev/80a41fb9b523 and bug 551773 will also need to land, there are bogus aborts killing tests on Linux
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.