551098 - windows mobile crashes on start up since xmalloc landing

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

changesets from bug 441324:
> http://hg.mozilla.org/mozilla-central/rev/d8c18f04396e
> http://hg.mozilla.org/mozilla-central/rev/5257693bcfbf
> http://hg.mozilla.org/mozilla-central/rev/81bd90ae5899
> http://hg.mozilla.org/mozilla-central/rev/130a52770a7b

caused a startup crash on Windows Mobile. Stack:

     0x03f666e0    
>	mozce_shunt.dll!arena_dalloc(arena_s* arena = 0x00000000, arena_chunk_s* chunk = 0x67bf39fe, void* ptr = 0xffffc808) Line: 4227, Byte Offsets: 0x38	C
     mozce_shunt.dll!putenv_internal(char* key = 0x00000000, char* value =
0x67bf39fe, int flag = -14328) Line: 102, Byte Offsets: 0xb8    C++
     mozce_shunt.dll!putenv(const char* envstr = 0x00000000) Line: 144, Byte
Offsets: 0x104    C++
     nspr4.dll!PR_SetEnv(const char* string = 0x00000000) Line: 97, Byte
Offsets: 0x80    C
     xul.dll!LaunchChild(nsINativeAppSupport* aNative = 0x00000000, int
aBlankCommandLine = 1740585470) Line: 1722, Byte Offsets: 0x50    C++
     xul.dll!XRE_main(int argc = 0, char** argv = 0x67bf39fe, nsXREAppData*
aAppData = 0xffffc808) Line: 3596, Byte Offsets: 0x2958    C++
     fennec.exe!NS_internal_main(int argc = 0, char** argv = 0x67bf39fe) Line:
147, Byte Offsets: 0x2f0    C++
     fennec.exe!wmain(int argc = 0, wchar_t** argv = 0x67bf39fe) Line: 120,
Byte Offsets: 0x178    C++
     fennec.exe!mainWCRTStartup(HINSTANCE__* hInstance = 0x00000000,
HINSTANCE__* hInstancePrev = 0x67bf39fe, unsigned short* lpszCmdLine =
0xffffc808, int nCmdShow = 0) Line: 188, Byte Offsets: 0x94    C++
     0x03f672ac

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 431279 [details] [diff] [review]
patch

>diff --git a/build/wince/shunt/memory.cpp b/build/wince/shunt/memory.cpp
>--- a/build/wince/shunt/memory.cpp
>+++ b/build/wince/shunt/memory.cpp
>@@ -30,26 +30,24 @@
>  * under the terms of either the GPL or the LGPL, and not to allow others to
>  * use your version of this file under the terms of the MPL, indicate your
>  * decision by deleting the provisions above and replace them with the notice
>  * and other provisions required by the GPL or the LGPL. If you do not delete
>  * the provisions above, a recipient may use your version of this file under
>  * the terms of any one of the MPL, the GPL or the LGPL.
>  *
>  * ***** END LICENSE BLOCK ***** */
> 
> #include "include/mozce_shunt.h"
> #include <stdlib.h>
> 
>-#include "mozilla/mozalloc_macro_wrappers.h" /* infallible malloc */
>-
> #ifdef MOZ_MEMORY
> 
> // declare the nothrow object
> const std::nothrow_t std::nothrow;
> 
> char*
> _strndup(const char *src, size_t len) {
>   char* dst = (char*)malloc(len + 1);
>   // FIXME/bug 507249: no need to null-check when infallible
>   // allocators are used

Nit: ought to nuke these comments.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/7132cc43b849

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

turns out this patch breaks the build after a clobber

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: followup patch

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/47a442f5c0dc

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

I clobbered all builders after landing this last night and they've all cycled green at least once now (so at least one clobber build and one dep build)