551127 - Crash in nsFilePicker Qt port [@ nsFilePicker::InitNative]

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[jkk]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/8.04 (hardy) Firefox/3.0.11
Build Identifier: 

Switch from QWidget to QGraphicsWidget in Qt port of XULRunner introduced a crash in file picker dialog

Reproducible: Always

Steps to Reproduce:
1. Go to download.com
2. Try to download file
3. Click 'Save' from dialog


Actual Results:  
Crash

Expected Results:  
File picker dialog to be shown.

Comment 1

[jkk]

Attachment: Proposal patch for fixing file picker crash

Comment 2

[timeless]

please add:
[diff]
git=1
showfunc=true

to your .hgrc file

and please provide a stack trace, or at least [@ foo] in the summary, so that others can find your bug when they encounter the same crash. I've made a guess at the crashing function, if i'm wrong, please fix the summary. Also, please try to file bugs where they belong. you can use (bonsai) hg blame/log to find out which bugs recently affected the relevant file and from there which components cover your code.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 431311 [details] [diff] [review]
Proposal patch for fixing file picker crash

can scene() be null?

Comment 4

[jkk]

(In reply to comment #3)
> (From update of attachment 431311 [details] [diff] [review])
> can scene() be null?

I think that at this point of execution there must be scene available.

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 431311 [details] [diff] [review]
Proposal patch for fixing file picker crash

i'd add a  NS_ASSERTION(parentWidget->scene())

Just to be safe.  

Otherwise, it looks fine.

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/81a5af9b8a1f

instead of the assertion, i am checking for a valid scene.

Comment 7

[Doug Turner (:dougt)]

jkk - thank you for the fix!