551199 - "datetime_format_inbound" not found when calling Bug.search()

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Frédéric Buclin]

When testing mkanat's patch from http://landfill.bugzilla.org/bugzillaqa/show_bug.cgi?id=3153, I get:

# Application failed during request deserialization: Can't locate object method "datetime_format_inbound" via package "Bugzilla::XMLRPC::Deserializer" at Bugzilla/WebService/Server/XMLRPC.pm line 114.

Comment 1

[Frédéric Buclin]

Hum, this is a regression. I cannot reproduce on 3.4.6.

Comment 2

[Max Kanat-Alexander]

Okay, we keep getting into trouble because of the confusion between how the XML-RPC WebService class structure works, and how the JSON-RPC WebService class structure works. So for head, I'm going to simplify all of this, but for the 3.6 branch, I'll just do a quick fix.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Simple fix. datetime_format_inbound was being called in ::Serializer, but using $self.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 431635 [details] [diff] [review]
v1

Looks and works good. Passes the t/webservice_bug_search.t for me for me as well. Apologize for not running that before with my first review. r=dkl

Comment 5

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7061.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7030.