551281 - Inline pushback token check before JSTokenStream::getToken()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Inlines the pushback check.

Demonstrates decent speedup -- may be obsoleted by pump-priming approach, but worth putting into trunk. Diff depends on attachment to bug 549658.

{
   "tetris_combined.js": {"average_ms":  19.13, "stddev_ms":   0.34},
  "gravity_combined.js": {"average_ms": 118.24, "stddev_ms":   0.51},
                "ga.js": {"average_ms":  13.86, "stddev_ms":   0.37},
     "jsgb_combined.js": {"average_ms":  46.78, "stddev_ms":   0.44},
        "jquery.min.js": {"average_ms":  24.28, "stddev_ms":   0.53},
  "twitter_combined.js": {"average_ms":  90.64, "stddev_ms":   7.99},
"280slides_combined.js": {"average_ms":  15.70, "stddev_ms":   0.46},
    "gmail_combined.js": {"average_ms": 444.38, "stddev_ms":  16.00},
              "dojo.js": {"average_ms":  33.27, "stddev_ms":   0.44},
       "v8_combined.js": {"average_ms":  95.32, "stddev_ms":   0.49},
 "processing_twitch.js": {"average_ms":  10.66, "stddev_ms":   0.47},
   "zimbra_combined.js": {"average_ms": 573.69, "stddev_ms":  16.95},
"effectgames_galaxy.js": {"average_ms":  71.46, "stddev_ms":   4.60},
"ball_pool_combined.js": {"average_ms":  71.16, "stddev_ms":   0.37},
           "yui-min.js": {"average_ms":   7.13, "stddev_ms":   0.34},
          "MochiKit.js": {"average_ms":  70.23, "stddev_ms":   0.42},
    "pipio_combined.js": {"average_ms": 392.71, "stddev_ms":  16.19},
"sunspider_combined.js": {"average_ms":  50.85, "stddev_ms":   0.48}
}

   tetris_combined.js: faster:  19.47ms < baseline  20.84ms ( +6.59%)
  gravity_combined.js: faster: 118.75ms < baseline 131.29ms ( +9.55%)
                ga.js: faster:  14.23ms < baseline  14.90ms ( +4.47%)
     jsgb_combined.js: faster:  47.22ms < baseline  50.87ms ( +7.18%)
        jquery.min.js: faster:  24.81ms < baseline  25.89ms ( +4.17%)
  twitter_combined.js: Meh.
280slides_combined.js: faster:  16.16ms < baseline  16.82ms ( +3.93%)
    gmail_combined.js: faster: 460.38ms < baseline 474.41ms ( +2.96%)
              dojo.js: faster:  33.71ms < baseline  36.81ms ( +8.41%)
       v8_combined.js: faster:  95.81ms < baseline 104.01ms ( +7.89%)
 processing_twitch.js: Meh.
   zimbra_combined.js: faster: 590.64ms < baseline 620.23ms ( +4.77%)
effectgames_galaxy.js: Meh.
ball_pool_combined.js: faster:  71.53ms < baseline  78.91ms ( +9.36%)
           yui-min.js: faster:   7.47ms < baseline   7.59ms ( +1.63%)
          MochiKit.js: faster:  70.65ms < baseline  77.03ms ( +8.28%)
    pipio_combined.js: faster: 408.90ms < baseline 415.83ms ( +1.67%)
sunspider_combined.js: faster:  51.33ms < baseline  58.24ms (+11.87%)

Comment 1

[Jim Blandy :jimb]

Comment on attachment 431468 [details] [diff] [review]
Inlines the pushback check.

Looks good!

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

This went in along with http://hg.mozilla.org/tracemonkey/rev/52699e337fbc