551303 - Use QuartzGL for drawing

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

$summary

(Jeff dictated me both the patch and the bug description/summary, I'm just the delivery guy!)

Perf test case: http://www.tapper-ware.net/stable/web.dom.stresstest.transform/

Comment 1

[Josh Aas]

Have you run tests with this, and do you have Tp numbers? I'm happy to try this but I need to know that tests pass and that Tp won't regress.

Apparently the default NSWindowBackingLocation is determined by the OS - you'd think this would already be the default where possible.

Comment 2

[Josh Aas]

Also - what happens when you have this set and then we load a Quickdraw plugin?

Comment 3

[José Jeria]

Would this give the Mac builds the same performance improvement as Direct2D gave on Windows?

Comment 4

[Anthony Ricaud (:rik)]

Is it possible to land this with a pref set to off ? People could try it a bit and file bugs.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #4)
> Is it possible to land this with a pref set to off ? People could try it a bit
> and file bugs.

That seems like a good idea.

Comment 6

[Guillermo López :willyaranda (probably SLOW response)]

I don't have the knowledge to write a patch about Comment 4, but I think it's a good idea, preffed off

Comment 7

[Jean]

I'm much interested in this issue and I tried the stress test linked in the first post. In FF 4 beta 6, QuartzGL doesn't make a difference: 2-3 fps with 100% CPU usage.
On Safari 5, the difference is huge! Going from 5 fps to full 60 fps with CPU usage dropping from 100% to 25%. It could probably go way over 60fps without Vsync, although disabling beam sync makes things worse, for some reason. 

2.4 GHz MacBook Pro with geforce 9400M, OS X 10.6.4, safari 5.0.2.

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: v0.1

I've taken the patch from Ehsan and added a pref with the necessary code (I think!) to get that working.

It's not tested, I'm compiling right now (a debug build, is it better to compile with any specific args?)

Comment 9

[Guillermo López :willyaranda (probably SLOW response)]

So I've compiled a Debug build with my patch, and just with the patch from Ehsan and the URL example doesn't work as in Safari. I have enabled just Quartz Extreme (Force QuartzGL in Quartz Debug app seems to not do anything)

Safari: around 60fps
Firefox: around 15fps

Are we missing something?

Comment 10

[Anthony Ricaud (:rik)]

I just tried a Firefox nightly with Quartz Debug.

I don't see any improvements with QuartzGL activated but it's smooth with Quartz Extreme. Going from 20 to 60ps.

I also get better performance on the Flying images IE demo. 40fps with QE, 10fps without (36 images)

Comment 11

[Markus Stange [:mstange]]

Quartz Extreme isn't something we can influence, as far as I know. It's a system-wide setting for window composition and it's on by default.

Comment 12

[Anthony Ricaud (:rik)]

Yeah sorry for the bogus comment. I understood that Quartz Extreme was on by default when it was smooth even with Quartz Debug turned off.

Comment 13

[Ali Juma [:ajuma]]

When we're ready to implement content acceleration on OS X, we'll likely use the Core Animation APIs rather than the older QuartzGL.