551354 - Review the preferences service module, jetpack-core/lib/preferences-service.js

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Drew Willcoxon :adw]

http://hg.mozilla.org/labs/jetpack-sdk/file/tip/packages/jetpack-core/lib/preferences-service.js

Module description from the docs:

The preferences-service module provides access to the application-wide preferences service singleton.

Comment 1

[Dietrich Ayala (:dietrich)]

r=me. the only change i saw is to get the prefs service lazily. very minor.

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: v1

Comment 3

[Erik Vold]

setting max/min int values in preferences module directly to their values, instead of calculating them on load. Also made a small correction for MIN_INT, it is actaully 1 less than it was set to previously.
- http://github.com/erikvold/jetpack-sdk/commit/3c421f62852f8fc424114a9c43f475acd339cee9.patch
- http://github.com/mozillalabs/jetpack-sdk/pull/4

adding getChildList method to the preferences-service module, with tests and docs.
- http://github.com/erikvold/jetpack-sdk/commit/6cd8d436a537f01efdeb31bd481739c5409c1bd0
- http://github.com/mozillalabs/jetpack-sdk/pull/5

Comment 4

[Erik Vold]

Is there some reason why there is not a remove method?

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Given the length of time this code has been in the tree, and the exposure it has received, it doesn't seem like additional review at this point is worth the cost, with the exception of the cuddlefish module, about which concerns have been raised, so closing these bugs WONTFIX, except for that one.